--- Begin Message ---
|
Subject: |
25.0.50; Around advice doesn't seem to work |
|
Date: |
Wed, 08 Jul 2015 13:28:57 +0600 |
Reproducible with ‘emacs -Q’:
(defun mk-anti-ido-advice (func &rest args)
"Temporarily disable IDO and call function FUNC with arguments ARGS."
(message "Called!")) ;; just for testing
(defun mk-disable-ido (command)
"Disable IDO when command COMMAND is called."
(advice-add command :around #'mk-anti-ido-advice))
(mk-disable-ido 'dired-create-directory)
Now, in description of ‘dired-create-directory’ one can see that
‘:around’ advice is registered. However, when I call
‘dired-create-directory’ either via ‘+’ keybinding or via ‘M-x
dired-create-directory’, old version of the function is called. I don't
see "Called!" message in the minibuffer. Is it bug or feature?
In GNU Emacs 25.0.50.14 (x86_64-unknown-linux-gnu, GTK+ Version 3.16.4)
of 2015-07-06 on arch
Repository revision: 8c81ac97fdd0d1dff7256dace45bdd48324a0963
Windowing system distributor `The X.Org Foundation', version 11.0.11702000
Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS
NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11
Important settings:
value of $LANG: en_US.UTF-8
locale-coding-system: utf-8-unix
Major mode: ε
Minor modes in effect:
diff-auto-refine-mode: t
rainbow-delimiters-mode: t
flycheck-mode: t
flyspell-mode: t
whitespace-mode: t
yas-global-mode: t
yas-minor-mode: t
show-paren-mode: t
minibuffer-electric-default-mode: t
ido-vertical-mode: t
ido-ubiquitous-mode: t
ido-everywhere: t
global-auto-revert-mode: t
global-aggressive-indent-mode: t
aggressive-indent-mode: t
display-time-mode: t
delete-selection-mode: t
smartparens-global-mode: t
smartparens-mode: t
tooltip-mode: t
global-eldoc-mode: t
eldoc-mode: t
electric-indent-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
column-number-mode: t
line-number-mode: t
auto-fill-function: do-auto-fill
transient-mark-mode: t
auto-fill-mode: 1
Recent messages:
nil
Quit
[2 times]
uncompressing nadvice.el.gz...done
Note: file is write protected
Unused lexical argument `func'
Unused lexical argument `args'
Saving file /home/mark/.emacs.d/mk/mk-utils.el...
Wrote /home/mark/.emacs.d/mk/mk-utils.el
Load-path shadows:
None found.
Features:
(shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml
mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils dired-aux smex vc vc-dispatcher vc-git diff-mode
jka-compr ace-window eieio-opt speedbar sb-image ezimage dframe help-fns
hl-line rainbow-delimiters flycheck-haskell haskell-cabal haskell-utils
flycheck find-func rx subr-x flyspell ispell whitespace mk-visual
solarized-dark-theme solarized mk-texinfo mk-tex mk-scheme mk-python
mk-prolog mk-org mk-markdown mk-man mk-magit mk-lisp slime-fancy
slime-trace-dialog slime-fontifying-fu slime-package-fu slime-references
slime-compiler-notes-tree slime-scratch slime-presentations bridge
slime-fuzzy slime-fancy-trace slime-fancy-inspector slime-c-p-c
slime-editing-commands slime-autodoc slime-repl slime-parse slime
compile etags xref eieio eieio-core arc-mode archive-mode noutline
outline pp comint ansi-color ring hyperspec browse-url slime-autoloads
mk-ibuffer mk-haskell mk-gnus mk-eshell mk-erc mk-elisp mk-dired dired-x
dired mk-diff mk-clojure mk-calendar mk-c mk-bookmark mk-minor-modes
common-lisp-snippets yasnippet help-mode cl whole-line-or-region paren
minibuf-eldef ido-vertical-mode ido-ubiquitous ido-completing-read+
cl-macs gv ido autorevert filenotify cl-seq aggressive-indent easy-mmode
time delsel smartparens-config smartparens byte-opt thingatpt mk-global
edmacro kmacro ace-link avy mk-utils f dash s ucs-normalize mk-abbrev
misc server finder-inf tex-site fix-word advice info easymenu bytecomp
byte-compile cl-extra seq cl-loaddefs pcase cl-lib cconv package
epg-config time-date mule-util tooltip eldoc electric uniquify
ediff-hook vc-hooks lisp-float-type mwheel x-win term/common-win x-dnd
tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment
elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan
thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian
slovak czech european ethiopic indian cyrillic chinese charscript
case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote dbusbind gfilenotify
dynamic-setting system-font-setting font-render-setting move-toolbar gtk
x-toolkit x multi-tty make-network-process emacs)
Memory information:
((conses 16 402680 107452)
(symbols 48 36493 0)
(miscs 40 146 690)
(strings 32 67281 51387)
(string-bytes 1 1887358)
(vectors 16 58733)
(vector-slots 8 1714519 246291)
(floats 8 375 464)
(intervals 56 2202 800)
(buffers 976 19)
(heap 1024 45676 7373))
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#21007: 25.0.50; Around advice doesn't seem to work |
|
Date: |
Wed, 08 Jul 2015 10:43:59 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) |
Mark Karpov <address@hidden> writes:
>> I see a prompt for a directory, but when I hit RET to confirm, I get a
>> "Called!" message.
>>
>> If that's what you see also and you don't want to see the prompt,
>> simply make mk-anti-ido-advice an (interactive) function (the new
>> interactive spec will replace the old one).
>
> Thank you, this should be closed now.
Done.
(BTW you can also do it yourself, by simply appending "-done" to the bug
number in the mail address: address@hidden)
Nico.
--- End Message ---