--- Begin Message ---
Subject: |
25.0.50; [PATCH] Prevent empty -path arguments for not-ignored directories in rgrep's find commands |
Date: |
Thu, 24 Sep 2015 23:28:39 +1200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 |
In GNU Emacs 25.0.50.1 (x86_64-unknown-linux-gnu, X toolkit, Xaw3d
scroll bars)
of 2015-09-05
Repository revision: 2330ca33a97867f2ea1123bcf7bfe5cfcc030b36
rgrep's `grep-find-ignored-directories' conditional-ignore behaviour
(for list elements which are cons cells) produces 'find' constraints
like: "find . -type d \( -path -o -path \*/SCCS [...]" (i.e. a -path
argument with no value) when the associated function returns nil.
The nil elements need to be deleted from the list before the command
line arguments for the ignored directories are generated.
0001-Prevent-empty-path-arguments-in-rgrep-find-commands.patch
Description: Text Data
--- End Message ---
--- Begin Message ---
Subject: |
Re: bug#21548: 25.0.50; [PATCH] Prevent empty -path arguments for not-ignored directories in rgrep's find commands |
Date: |
Wed, 30 Sep 2015 10:43:30 +0300 |
> Date: Thu, 24 Sep 2015 23:28:39 +1200
> From: Phil Sainty <address@hidden>
>
> rgrep's `grep-find-ignored-directories' conditional-ignore behaviour
> (for list elements which are cons cells) produces 'find' constraints
> like: "find . -type d \( -path -o -path \*/SCCS [...]" (i.e. a -path
> argument with no value) when the associated function returns nil.
>
> The nil elements need to be deleted from the list before the command
> line arguments for the ignored directories are generated.
Thanks, I pushed this.
Please in the future accompany your patches with a ChangeLog-format
commit message; see CONTRIBUTE for details.
We seem to lack tests for this stuff (and Grep in general). Would you
like to write some tests for that? TIA.
--- End Message ---