[debbugs-tracker] bug#21117: closed ([PATCH 4/4] Remove sigevent structure value definitions)

[GNU bug Tracking System]

Your message dated Thu, 29 Oct 2015 23:46:30 +0100
with message-id <address@hidden>
and subject line Re: bug#21117: [PATCH 4/4] Remove sigevent structure value 
definitions
has caused the debbugs.gnu.org bug report #21117,
regarding [PATCH 4/4] Remove sigevent structure value definitions
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
21117: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=21117
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 4/4] Remove sigevent structure value definitions
>
>
>
>
> Date: 
>
> Wed, 22 Jul 2015 12:54:32 -0400
>
>
>
>
> * libguile/Makefile.am (chknew-E chknew-SIG): Anchor the end of the
>   signal/error name pattern to only match alphanumeric symbols.
> * libguile/cpp-SIG.syms (SIGEV_MAX_SIZE, SIGEV_NONE): Remove.
>   (SIGEV_PAD_SIZE, SIGEV_SIGNAL, SIGEV_THREAD): Likewise.
>   (SIGEV_THREAD_ID): Likewise.
> ---
>
>
> I'm assuming those sigevent structure values weren't intended to have
> their definitions included with signals.  This patch removes them and
> adds stricter name matching to the regexp.
>
>
>  libguile/Makefile.am  | 2 +-
>  libguile/cpp-SIG.syms | 6 ------
>  2 files changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/libguile/Makefile.am b/libguile/Makefile.am
> index dfa3be0..851799a 100644
> --- a/libguile/Makefile.am
> +++ b/libguile/Makefile.am
> @@ -821,7 +821,7 @@ chknew-E chknew-SIG:
>         echo "#include <$${bit}.h>"                             \
>          | sed 's/E/errno/;s/SIG/signal/'                       \
>          | gcc -dM -E -                                         \
> -        | sed 's/^#define //;/^'$$bit'[0-9A-Z][0-9A-Z]*/!d;s/ .*//'    \
> +        | sed 's/^#define //;/^'$$bit'[0-9A-Z][0-9A-Z]* /!d;s/ .*//'   \
>          | sort | diff -u $$old - | sed '1,2d;/^+/!d;s/^.//'    \
>          > TMP ;                                                \
>         if [ -s TMP ] ; then new="$$old.NEW" ;                  \
> diff --git a/libguile/cpp-SIG.syms b/libguile/cpp-SIG.syms
> index 2a619ce..728a294 100644
> --- a/libguile/cpp-SIG.syms
> +++ b/libguile/cpp-SIG.syms
> @@ -6,12 +6,6 @@ SIGCHLD
>  SIGCLD
>  SIGCONT
>  SIGEMT
> -SIGEV_MAX_SIZE
> -SIGEV_NONE
> -SIGEV_PAD_SIZE
> -SIGEV_SIGNAL
> -SIGEV_THREAD
> -SIGEV_THREAD_ID
>  SIGFPE
>  SIGHUP
>  SIGILL
> -- 
> 2.1.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#21117: [PATCH 4/4] Remove sigevent structure value definitions
>
>
>
>
> Date: 
>
> Thu, 29 Oct 2015 23:46:30 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
>
>
>
>
> David Michael <address@hidden> skribis:
>
> > * libguile/Makefile.am (chknew-E chknew-SIG): Anchor the end of the
> >   signal/error name pattern to only match alphanumeric symbols.
> > * libguile/cpp-SIG.syms (SIGEV_MAX_SIZE, SIGEV_NONE): Remove.
> >   (SIGEV_PAD_SIZE, SIGEV_SIGNAL, SIGEV_THREAD): Likewise.
> >   (SIGEV_THREAD_ID): Likewise.
> > ---
> >
> >
> > I'm assuming those sigevent structure values weren't intended to have
> > their definitions included with signals.  This patch removes them and
> > adds stricter name matching to the regexp.
>
> Good catch.  Pushed as c3f95ec.
>
> Thanks!
>
> Ludo’.
>
>
> --- End Message ---