--- Begin Message ---
|
Subject: |
24.5; vc-git-command should use coding-system-for-read |
|
Date: |
Mon, 21 Mar 2016 14:22:36 +0300 |
|
User-agent: |
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
If you have files in your repositories, that are in different coding
system from vc-git-commits-coding-system, vc-diff would still show diffs
for them in vc-git-commits-coding-system.
This is unnecessary, since vc-diff-internal already decides what coding
system to use based on the first file and then sets
coding-system-for-read accordingly.
The fix is to change vc-git-command to use coding-system-for-read
whenever it's bound.
--
Best Regards,
Nikolay Kudryavtsev
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#23075: 24.5; vc-git-command should use coding-system-for-read |
|
Date: |
Sat, 02 Apr 2016 12:58:33 +0300 |
> From: Nikolay Kudryavtsev <address@hidden>
> Cc: address@hidden
> Date: Mon, 21 Mar 2016 21:45:40 +0300
>
> 1. Clone https://github.com/sg2002/vc-git-bugs
> 2. Open 1251.txt in windows1251 encoding. Do some changes in it.
> 3. vc-diff. This would give you diff with broken encoding.
> 4. Evaluate vc-git-command from fix.el in the repo.
> 5. vc-diff again, it would give you the correct encoding as long as the
> file itself opened correctly.
>
> Yes, there is some code that specifies encoding in vc already. See the
> first large comment in vc-diff-internal.
>
> This issue is not platform specific, unlike 23076.
Thanks, this should now be fixed by commit 17b5152.
I'm closing this bug report. Feel free to reopen if any issues remain
unresolved.
--- End Message ---