[debbugs-tracker] bug#23356: closed ([PATCH] Cache results of `css--property-values')

[GNU bug Tracking System]

Your message dated Sun, 24 Apr 2016 15:07:50 +0200
with message-id <address@hidden>
and subject line Re: bug#23356: [PATCH] Cache results of `css--property-values'
has caused the debbugs.gnu.org bug report #23356,
regarding [PATCH] Cache results of `css--property-values'
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
23356: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=23356
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] Cache results of `css--property-values' Date: Sun, 24 Apr 2016 14:44:50 +0200

During one of the iterations for 269d5631 (Support completion of

attribute values in CSS mode), the code that actually updates the

`css--property-value-cache' cache in `css--property-values' got lost.

The attached patch reintroduces it along with a regression test.

--Simen

0001-Cache-results-of-css-property-values.patch
Description: Text Data

--- End Message ---

--- Begin Message --- Subject: Re: bug#23356: [PATCH] Cache results of `css--property-values' Date: Sun, 24 Apr 2016 15:07:50 +0200 On Sun, Apr 24, 2016 at 3:00 PM, Dmitry Gutov <address@hidden> wrote:

LGTM.

Thanks for the review, installed in master.

You should be able to push this kind of changes without going through review anyway.

I thought so too, but I wasn't entirely sure. I'll adjust my threshold

then for what I can go ahead with without a review.

-- Simen

--- End Message ---