[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#20645: closed (sxml xpath exports "filter")

From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#20645: closed (sxml xpath exports "filter")
Date: Thu, 23 Jun 2016 16:44:02 +0000

Your message dated Thu, 23 Jun 2016 12:42:55 -0400
with message-id <address@hidden>
and subject line Re: bug#20645: sxml xpath exports "filter"
has caused the debbugs.gnu.org bug report #20645,
regarding sxml xpath exports "filter"
to be marked as done.

(If you believe you have received this mail in error, please contact

20645: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20645
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: sxml xpath exports "filter" Date: Sun, 24 May 2015 08:34:21 -0700
sxml xpath exports "filter" which is incompatible with the common procedure of 
the same name.

I suggest renaming unless it breaks a lot of code.

I use

  #:use-module ((sxml xpath)
                #:renamer (lambda (s) (if (eq? s 'filter) 'xp-filter s)))

but would rather other agree that renaming in sxml/xpath.scm is better.


--- End Message ---
--- Begin Message --- Subject: Re: bug#20645: sxml xpath exports "filter" Date: Thu, 23 Jun 2016 12:42:55 -0400 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (gnu/linux)
Mark H Weaver <address@hidden> writes:

> Matt Wette <address@hidden> writes:
>> This is a very annoying "bug".  The (sxml xpath) “filter” procedure 
>> overrides the builtin guile “filter”.
>> I believe the fix can be implemented with the following changes to (sxml 
>> xpath):
>> 1) (define node-filter filter)
>> 2) In the #:export list, replace “filter” with “node-filter”
> We can't do this because it would break existing code that uses 'filter'
> from (sxml xpath), and also introduce a Guile-specific change to the API
> of a portable library.
> However, you can rename 'filter' at import time as follows:
>   (use-modules ((sxml xpath) #:select ((filter . node-filter))))
> Does this work for you?

Having not heard back for 19 weeks, I'm closing this bug now.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]