emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#23787: closed ([PATCH] * lisp/bindings.el: create


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#23787: closed ([PATCH] * lisp/bindings.el: create binding for ‘cycle-spacing’)
Date: Fri, 24 Jun 2016 22:15:03 +0000

Your message dated Sat, 25 Jun 2016 00:14:17 +0200
with message-id <address@hidden>
and subject line Re: [PATCH] * lisp/bindings.el: create binding for 
‘cycle-spacing’
has caused the debbugs.gnu.org bug report #23787,
regarding [PATCH] * lisp/bindings.el: create binding for ‘cycle-spacing’
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
23787: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=23787
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: [PATCH] * lisp/bindings.el: create binding for ‘cycle-spacing’ Date: Fri, 17 Jun 2016 22:12:16 +0200
‘cycle-spacing’ behaves like ‘just-one-space’ when invoked once so
binding it to M-SPC should not be (very) destructive to users.

When this change has been propesed back in 2014¹, the main concern
was that back then the function behaved a bit differently from the
old one in certain situations.  This has since been changed by a
[687e0e1: “Make ‘cycle-spacing’ behave more like ‘just-one-space’
if colled once.”] commit.

¹ https://lists.gnu.org/archive/html/emacs-devel/2014-01/msg02183.html
---
 etc/NEWS         | 6 ++++++
 lisp/bindings.el | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

 Unless there are objections, I’ll submit this in a week.  I’ve CC’d
 everyone who was involved in the original thread.

diff --git a/etc/NEWS b/etc/NEWS
index d8583cf..1041239 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -187,6 +187,12 @@ questions, with a handy way to display help texts.
 'undo', undo the last replacement; bound to 'u'.
 'undo-all', undo all replacements; bound to 'U'.
 
+** M-SPC is now bound to 'cycle-spacing'.
+When called once, 'cycle-spacing' behaves the same way
+'just-one-space' does so this change should not disturb any old
+habits.  When pressed multiple times it manipulate whitespace around
+point in a smart way giving user more editing powers.
+
 
 * Changes in Specialized Modes and Packages in Emacs 25.2
 
diff --git a/lisp/bindings.el b/lisp/bindings.el
index c13f4b1..cf9aaf3 100644
--- a/lisp/bindings.el
+++ b/lisp/bindings.el
@@ -807,7 +807,7 @@ esc-map
 (define-key esc-map "\\" 'delete-horizontal-space)
 (define-key esc-map "m" 'back-to-indentation)
 (define-key ctl-x-map "\C-o" 'delete-blank-lines)
-(define-key esc-map " " 'just-one-space)
+(define-key esc-map " " 'cycle-spacing)
 (define-key esc-map "z" 'zap-to-char)
 (define-key esc-map "=" 'count-words-region)
 (define-key ctl-x-map "=" 'what-cursor-position)
-- 
2.8.0.rc3.226.g39d4020




--- End Message ---
--- Begin Message --- Subject: Re: [PATCH] * lisp/bindings.el: create binding for ‘cycle-spacing’ Date: Sat, 25 Jun 2016 00:14:17 +0200 User-agent: Notmuch/0.19+53~g2e63a09 (http://notmuchmail.org) Emacs/25.1.50.11 (x86_64-unknown-linux-gnu)
On Fri, Jun 17 2016, Michal Nazarewicz wrote:
>  Unless there are objections, I’ll submit this in a week.  I’ve CC’d
>  everyone who was involved in the original thread.

Since there indeed were objections (which themselves had objections
raised, but still), I’m dropping this.

-- 
Best regards
ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ
«If at first you don’t succeed, give up skydiving»


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]