[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#21266: closed ([PATCH] dfa: simplify for non-POSIX

From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#21266: closed ([PATCH] dfa: simplify for non-POSIX locales)
Date: Wed, 06 Jul 2016 17:56:02 +0000

Your message dated Wed, 6 Jul 2016 19:55:47 +0200
with message-id <address@hidden>
and subject line Re: [PATCH] dfa: simplify for non-POSIX locales
has caused the debbugs.gnu.org bug report #21266,
regarding [PATCH] dfa: simplify for non-POSIX locales
to be marked as done.

(If you believe you have received this mail in error, please contact

21266: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=21266
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: [PATCH] dfa: simplify for non-POSIX locales Date: Sun, 16 Aug 2015 00:51:16 +0900
Now dfa is not support range, collating element, equivalent class in
non-POSIX locales.  We can do dfa more simply by removing codes for them.

First, I made update dfaexec_main.  Now transit_state is called only
when next character matches with ANYCHAR, and match_anychar always
returns the length of the multibyte character for next character at all
positions in the state.  So we can remove match_anychar.  Further more,
we can also remove check_matching_with_multibyte_ops, which is caller
for match_anychar.

Second, dfa does not support collating element, we can also simplify

In addition, simplify transit_state_singlebyte.

Attachment: 0001-dfa-simplify-for-non-POSIX-locales.patch
Description: Text document

--- End Message ---
--- Begin Message --- Subject: Re: [PATCH] dfa: simplify for non-POSIX locales Date: Wed, 6 Jul 2016 19:55:47 +0200 User-agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 Thanks, I merged those two patches and installed them into the grep master, with minor adjustments to the commit messages. I also installed two minor fixup patches, mostly fixing minor style issues. I did notice one minor technical issue; the second patch had code that looked like this:

 +  context = (wc == (wchar_t) eolbyte || wc == 0) ? CTX_NEWLINE : CTX_NONE;

I realize this came from the old wchar_context function, but I don't see why that "|| wc == 0" is there, so I removed it. The tests still pass. If you (or someone else) can explain why it's needed I can put it back in.

Attached are the four patches I installed; the first and third are your patches and the second and fourth are the fixups.

Attachment: 0001-dfa-simplify-for-non-POSIX-locales.patch
Description: Text Data

Attachment: 0002-dfa-minor-cleanups-for-non-POSIX-simplification.patch
Description: Text Data

Attachment: 0003-dfa-don-t-distingish-letter-in-non-POSIX-locales.patch
Description: Text Data

Attachment: 0004-dfa-don-t-treat-null-bytes-specially.patch
Description: Text Data

--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]