--- Begin Message ---
Subject: |
[PATCH] grep: fix crash with a pattern of alternation of two same characters |
Date: |
Fri, 15 Jul 2016 00:07:13 +0900 |
Current master crashes with below.
$ printf '0\n0' >pat
$ printf '0\n' >in
$ env LC_ALL=C grep -F pat in
grep -F uses memchr2() for each character in this pattern, but if two
characters is same, the trie has no child.
0001-grep-fix-crash-with-a-pattern-of-alternation-of-two-.patch
Description: Text document
--- End Message ---
--- Begin Message ---
Subject: |
Re: bug#23983: [PATCH] grep: fix crash with a pattern of alternation of two same characters |
Date: |
Thu, 14 Jul 2016 20:00:35 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 |
On 07/14/2016 07:32 PM, Eric Blake wrote:
Could you instead do:
Something like that should work, but the original patch seems more
straightforward. As it happens I installed the attached before seeing
your email. The first is the original patch but with comments spruced up
a bit, mostly for English. The second is a minor style change.
0001-grep-fix-F-crash-when-alternating-duplicates.patch
Description: Text Data
0002-grep-minor-style-changes-for-F-crash-fix.patch
Description: Text Data
--- End Message ---