[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#24149: closed (25.1; set-transient-map bug)

From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#24149: closed (25.1; set-transient-map bug)
Date: Thu, 04 Aug 2016 15:48:02 +0000

Your message dated Thu, 04 Aug 2016 23:47:48 +0800
with message-id <address@hidden>
and subject line Re: bug#24149: 25.1; set-transient-map bug
has caused the debbugs.gnu.org bug report #24149,
regarding 25.1; set-transient-map bug
to be marked as done.

(If you believe you have received this mail in error, please contact

24149: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=24149
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: 25.1; set-transient-map bug Date: Thu, 04 Aug 2016 20:17:04 +0800
1. Enable temp-buffer-browse-mode
2. (cl-loop repeat 2 do (with-output-to-temp-buffer "*test*" (princ "ok")))
3. Check pre-command-hook

#:clear-transient-map will be there forever.

The issue is caused by two identical calls of set-transient-map that
share the same keymap. so deactivation of the second call has an
side-effect on the first call.

Stefan, is the following the right fix?


diff --git a/lisp/subr.el b/lisp/subr.el
index 2c0be204..b6a38778 100644
--- a/lisp/subr.el
+++ b/lisp/subr.el
@@ -4542,7 +4542,8 @@ to deactivate this transient map, regardless of 
             (with-demoted-errors "set-transient-map PCH: %S"
               (unless (cond
                        ((null keep-pred) nil)
-                       ((not (eq map (cadr overriding-terminal-local-map)))
+                       ((and (keymapp (cadr overriding-terminal-local-map))
+                             (not (eq map (cadr 
                         ;; There's presumably some other transient-map in
                         ;; effect.  Wait for that one to terminate before we
                         ;; remove ourselves.

--- End Message ---
--- Begin Message --- Subject: Re: bug#24149: 25.1; set-transient-map bug Date: Thu, 04 Aug 2016 23:47:48 +0800 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (OS X 10.11.6)
On 2016-08-04 09:20 -0400, Stefan Monnier wrote:
> If it works and looks good to you, please install it.

I agree it is a better fix. Pushed commit 84714016 to master.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]