[debbugs-tracker] bug#24423: closed (Proposal to set buffer not-modified when downloading a sieve script)

[GNU bug Tracking System]

Your message dated Tue, 13 Sep 2016 08:08:45 +0900
with message-id <address@hidden>
and subject line Re: bug#24423: Proposal to set buffer not-modified when 
downloading a sieve script
has caused the debbugs.gnu.org bug report #24423,
regarding Proposal to set buffer not-modified when downloading a sieve script
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
24423: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=24423
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: Proposal to set buffer not-modified when downloading a sieve script Date: Mon, 12 Sep 2016 16:03:18 -0400 User-agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/24.4 (gnu/linux)

Hi,

Because sieve-edit-script() does not set buffer not-modified when
downloading a sieve script, so, a user including muself cannot
distinguish whether the viewing script is modified or not modified from
the downloaded script on the managesieve server.

If sieve-edit-script() set buffer not-modified when downloading a sieve
script, a user can distinguish its modified status easily.

Therefore, I propose the following patch.

-- 
TSUCHIYA Masatoshi

--- a/lisp/sieve.el
+++ b/lisp/sieve.el
@@ -207,7 +207,8 @@ require \"fileinto\";
              err)
          (setq err (sieve-manage-getscript name newbuf sieve-manage-buffer))
          (switch-to-buffer newbuf)
-         (unless (sieve-manage-ok-p err)
+         (if (sieve-manage-ok-p err)
+             (set-buffer-modified-p nil)
            (error "Sieve download failed: %s" err)))
       (switch-to-buffer (get-buffer-create "template.siv"))
       (insert sieve-template))

signature.asc
Description: PGP signature

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#24423: Proposal to set buffer not-modified when downloading a sieve script
>
>
>
>
> Date: 
>
> Tue, 13 Sep 2016 08:08:45 +0900
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (i686-pc-cygwin)
>
>
>
>
> On Mon, 12 Sep 2016 16:03:18 -0400, TSUCHIYA Masatoshi wrote:
> > Because sieve-edit-script() does not set buffer not-modified when
> > downloading a sieve script, so, a user including muself cannot
> > distinguish whether the viewing script is modified or not modified from
> > the downloaded script on the managesieve server.
>
> > If sieve-edit-script() set buffer not-modified when downloading a sieve
> > script, a user can distinguish its modified status easily.
>
> > Therefore, I propose the following patch.
>
> The patch looks fine and useful.  I've committed it in the Emacs
> master with this log entry:
>
> sieve.el: Make the buffer to edit unmodified initially (bug#24423)
>
> * lisp/net/sieve.el (sieve-edit-script):
> Make the buffer to edit be not modified-p initially (bug#24423).
>
> Thanks.
>
>
> --- End Message ---