[debbugs-tracker] bug#24555: closed ([PATCH] Remove unused variable `command-debug-status')

[GNU bug Tracking System]

Your message dated Tue, 04 Oct 2016 17:43:18 +0300
with message-id <address@hidden>
and subject line Re: bug#24555: [PATCH] Remove unused variable 
`command-debug-status'
has caused the debbugs.gnu.org bug report #24555,
regarding [PATCH] Remove unused variable `command-debug-status'
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
24555: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=24555
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] Remove unused variable `command-debug-status' Date: Wed, 28 Sep 2016 14:39:02 +0200

Hello,

For information, I did the procedure for copyright assignment to Emacs and it is complete.

This patch removes the variable `command-debug-status', which really seems to be unused since a long time to me (that's what "git -G Vcommand-debug-status" says).

Philippe

0001-Remove-unused-variable-command-debug-status.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#24555: [PATCH] Remove unused variable `command-debug-status'
>
>
>
>
> Date: 
>
> Tue, 04 Oct 2016 17:43:18 +0300
>
>
>
>
> > From: Philippe Vaucher <address@hidden>
> > Date: Mon, 3 Oct 2016 09:42:14 +0200
> > Cc: Stefan Monnier <address@hidden>, address@hidden
> > 
> > And again new patches without a typo :-)
>
> Thanks, I pushed this to the emacs-25 branch, and I'm marking this
> bug done.
>
> Please note that your patch had a fatal flaw: specbind needs a
> (quoted) symbol, not its value.  Using Vcommand_debug_status there
> produced a broken binary that would display an error message and
> become unresponsive.  See what I actually committed for the details.
>
> Also, the obsolescence warning needed some minor tweaks (it turns out
> that my advice to prepend a semi-colon was a bad idea, as a semi-colon
> and a newline are produced by Emacs automatically).
>
> Please always test the build after you patch it, to make sure the
> behavior is correct and no bugs creep in.
>
> Finally, in the future please provide commit log messages for the
> changes formatted in the ChanegLog style, as described in CONTRIBUTE.
> I wrote them for this commit, please see the commit for the details of
> the formatting we use.
>
> Thanks a lot for working on this.
>
>
> --- End Message ---