emacs-bug-tracker
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#24660: closed (24.5; nxml-mode should support shif

From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#24660: closed (24.5; nxml-mode should support shift selection)
Date: Tue, 18 Oct 2016 06:47:01 +0000 
Your message dated Tue, 18 Oct 2016 09:46:19 +0300
with message-id <address@hidden>
and subject line Re: bug#24660: 24.5; nxml-mode should support shift selection
has caused the debbugs.gnu.org bug report #24660,
regarding 24.5; nxml-mode should support shift selection
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
24660: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=24660
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: 24.5; nxml-mode should support shift selection Date: Mon, 10 Oct 2016 22:41:37 +0600 
Many movement commands, such as forward-word, forward-sexp,
forward-sentence, next-line, and their backward counterparts, support
shift selection. That is, holding down Shift along with their bindings
causes region to be activated and/or extended.

$ emacs -Q

C-x C-f /tmp/test.xml

    <html>|<head></head><body></body></html>

C-M-S-<right> ;; C-M-<right> (translated) runs forward-sexp

    <html>[<head>]</head><body></body></html>

C-M-S-<right> ;; C-M-<right> (translated) runs forward-sexp

    <html>[<head></head>]<body></body></html>


However, nxml-mode’s commands do not behave this way.

    <html>|<head></head><body></body></html>

C-M-S-n ;; C-M-n (translated) runs nxml-forward-element

Expected:

    <html>[<head></head>]<body></body></html>

Observed:

    <html><head></head>|<body></body></html>


The attached patch fixes this for me. It is based on current master (fd45b3f).

Attachment: 0001-lisp-nxml-nxml-mode-Support-Shift-selection.patch
Description: Text Data


--- End Message ---
--- Begin Message --- Subject: Re: bug#24660: 24.5; nxml-mode should support shift selection Date: Tue, 18 Oct 2016 09:46:19 +0300 
> From: Yuri Khan <address@hidden>
> Date: Mon, 10 Oct 2016 22:41:37 +0600
> 
> Many movement commands, such as forward-word, forward-sexp,
> forward-sentence, next-line, and their backward counterparts, support
> shift selection. That is, holding down Shift along with their bindings
> causes region to be activated and/or extended.
> 
> $ emacs -Q
> 
> C-x C-f /tmp/test.xml
> 
>     <html>|<head></head><body></body></html>
> 
> C-M-S-<right> ;; C-M-<right> (translated) runs forward-sexp
> 
>     <html>[<head>]</head><body></body></html>
> 
> C-M-S-<right> ;; C-M-<right> (translated) runs forward-sexp
> 
>     <html>[<head></head>]<body></body></html>
> 
> 
> However, nxml-mode’s commands do not behave this way.
> 
>     <html>|<head></head><body></body></html>
> 
> C-M-S-n ;; C-M-n (translated) runs nxml-forward-element
> 
> Expected:
> 
>     <html>[<head></head>]<body></body></html>
> 
> Observed:
> 
>     <html><head></head>|<body></body></html>
> 
> 
> The attached patch fixes this for me. It is based on current master (fd45b3f).

Thanks, pushed to master.

In the future, please provide ChangeLog-style commit log messages as
described in CONTRIBUTE.

Also, I encourage you to start the legal paperwork for assigning to
the FSF the copyright of your changes, so that we could continue
accepting your contributions without any limitations.

--- End Message ---
reply via email to
[Prev in Thread] Current Thread [Next in Thread]