[debbugs-tracker] bug#24795: closed (sha1sum cannot find file to check)

[GNU bug Tracking System]

Your message dated Wed, 26 Oct 2016 15:55:56 +0100
with message-id <address@hidden>
and subject line Re: bug#24795: sha1sum cannot find file to check
has caused the debbugs.gnu.org bug report #24795,
regarding sha1sum cannot find file to check
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
24795: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=24795
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> sha1sum cannot find file to check
>
>
>
>
> Date: 
>
> Tue, 25 Oct 2016 19:26:24 +0200
>
>
>
>
> I'm using coreutils-8.25-2 on a Parabola GNU/Linux-libre system.
> I think I found a bug with the "sha1sum" command.
>
> Steps to reproduce:
> 1) wget https://dumps.wikimedia.org/enwikisource/20161020/enwikisource-
> 20161020-pages-articles.xml.bz2
> 2) wget https://dumps.wikimedia.org/enwikisource/20161020/enwikisource-
> 20161020-sha1sums.txt
> 3) sha1sum -c enwikisource-20161020-sha1sums.txt --ignore-missing
>
> Result:
> sha1sum: enwikisource-20161020-sha1sums.txt: no file was verified
>
> Expected result:
> enwikisource-20161020-pages-articles.xml.bz2: OK
>
> -- 
> https://www.fturco.net/
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: bug#24795: sha1sum cannot find file to check Date: Wed, 26 Oct 2016 15:55:56 +0100 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0

On 26/10/16 09:30, Francesco Turco wrote:
> On Tue, 2016-10-25 at 19:52 +0100, Pádraig Brady wrote:
>> This seems like the txt file is in DOS format with \r\n line endings.
>> If you remove the --ignore-missing option, are you presented with
>> $'\r' representations in the missing file names?
>> Though when I downloaded the file it was in unix format so I'm
>> confused
> 
> If I remove the --ignore-missing option no \r characters appear in the
> output, so the checksum file uses Unix line endings.
> 
> If I convert the checksum file to DOS line endings with unix2dos I can
> see \r line endings in the output.
> 
> There is another difference by using --ignore-missing: when using DOS
> line endings sha1sum immediately says "no file was verified", without
> checking anything; when using Unix line endings it says the same thing
> but after a few seconds, so it must have checked something behind the
> scenes.

Ouch that is a bug, triggered when --ignore-missing is used
with checksums that start with 00....
The attached should fix it up.

thanks,
Pádraig

md5sum--ignore-missing-00.patch
Description: Text Data

--- End Message ---