[debbugs-tracker] bug#23153: closed ([PATCH]: For FIXME in cp.c)

[GNU bug Tracking System]

Your message dated Thu, 3 Nov 2016 00:06:41 +0000
with message-id <address@hidden>
and subject line Re: bug#23153: [PATCH]: For FIXME in cp.c
has caused the debbugs.gnu.org bug report #23153,
regarding [PATCH]: For FIXME in cp.c
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
23153: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=23153
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH]: For FIXME in cp.c Date: Tue, 29 Mar 2016 20:58:01 +0530

Hello,

I have wrote the attached patch for following FIXME in file src/cp.c -

/* FIXME: consider not calling getenv for SIMPLE_BACKUP_SUFFIX unless
     we'll actually use backup_suffix_string.  */
  backup_suffix_string = getenv ("SIMPLE_BACKUP_SUFFIX");

Since we use backup_suffix_string to duplicate it into simple_backup_suffix, I brought the getenv() call there, that too, only if required (as simple_backup_suffix already stores tilde already).

I did 'diff -ur'  directly against original cp.c (named cp-original.c, then) to create the patch. I tested patch using -b, --backup and --suffix option of c. Version I have used is latest one on savannah.gnu.org - coreuitls-8.25.

There was cppi (didn't know what it does) at the bottom of coreutil's download page. After reading it's README, I concluded that it is not to be considered while debugging/fixing coreutils. Hopefully, I was correct in doing so.

If incorrect, please do correct me in any case. :)

There was one little doubt, maybe bug, after doing '--backups=numbered' it becomes impossible to have suffixed backups (using --suffix or -b) until we do '--backup=simple' explicitly. Is this supposed to be? I tried with both altered and unaltered version of cp.
(And should I have or should create/d a new separate thread? I wasn't sure.)

FIXME-calling-getnev.patch
Description: Text Data

--- End Message ---

--- Begin Message --- Subject: Re: bug#23153: [PATCH]: For FIXME in cp.c Date: Thu, 3 Nov 2016 00:06:41 +0000 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0

Attached are the two patches I intend to push for this
upon the next gnulib update.

Marking this bug as done.

thanks,
Pádraig

backupfile-cleanup.patch
Description: Text Data

--- End Message ---