[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#24941: closed (Early termination bug in grep 2.26)

From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#24941: closed (Early termination bug in grep 2.26)
Date: Sat, 19 Nov 2016 09:49:01 +0000

Your message dated Sat, 19 Nov 2016 01:47:48 -0800
with message-id <address@hidden>
and subject line Re: bug#24941: Early termination bug in grep 2.26
has caused the debbugs.gnu.org bug report #24941,
regarding Early termination bug in grep 2.26
to be marked as done.

(If you believe you have received this mail in error, please contact

24941: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=24941
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: Early termination bug in grep 2.26 Date: Sun, 13 Nov 2016 17:56:32 -0800 User-agent: Mutt/1.5.20 (2009-06-14)
There was some recent discussion on the vim_dev list of a failure to
update a Vim package which was found to be due to an update of grep
from 2.25 to 2.26.  The details of the grep behavior are discussed


In short, it seems to be due to the "grep: /dev/null output
speedup" commit of 2016-05-01, af6af288eac28951b5eee1eaaf373e22b2193b7b.
When grep terminates early, it closes the pipe it's reading stdin
from, which terminates the program on the other side of that pipe
early, before that program has completed its task.



--- End Message ---
--- Begin Message --- Subject: Re: bug#24941: Early termination bug in grep 2.26 Date: Sat, 19 Nov 2016 01:47:48 -0800 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 This turned into more work than I expected, as I kept finding performance glitches and/or correctness bugs in the neighborhood. I installed the attached set of patches. Patch 03 is the crucial one. Patch 10 trivially fixes an earlier test of mine and I'm too lazy to write a separate email for it.

This fixes the problem for me, so I'm taking the liberty of closing this bug 

Attachment: 0001-grep-avoid-unnecessary-isatty-calls.patch
Description: Text Data

Attachment: 0002-grep-improve-diagnostic-on-lseek-failure.patch
Description: Text Data

Attachment: 0003-grep-scale-back-dev-null-speedup.patch
Description: Text Data

Attachment: 0004-grep-drain-the-input-pipe-faster.patch
Description: Text Data

Attachment: 0005-grep-avoid-unnecessary-gettext-call.patch
Description: Text Data

Attachment: 0006-grep-avoid-O-N-2-buffer-reallocation.patch
Description: Text Data

Attachment: 0007-grep-treat-f-dev-null-like-m0.patch
Description: Text Data

Attachment: 0008-grep-tune-f-dev-null.patch
Description: Text Data

Attachment: 0009-grep-f-dev-null-L-PAT-FILE-outputs-FILE.patch
Description: Text Data

Attachment: 0010-tests-use-returns_-rather-than.patch
Description: Text Data

--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]