[debbugs-tracker] bug#24861: closed ([PATCH] Fix annoying "Parsing...done" message in c++-mode)

[GNU bug Tracking System]

Your message dated Fri, 25 Nov 2016 12:53:45 +0200
with message-id <address@hidden>
and subject line Re: bug#24861: [PATCH] Fix annoying "Parsing...done" message 
in c++-mode
has caused the debbugs.gnu.org bug report #24861,
regarding [PATCH] Fix annoying "Parsing...done" message in c++-mode
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
24861: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=24861
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] Fix annoying "Parsing...done" message in c++-mode
>
>
>
>
> Date: 
>
> Wed, 02 Nov 2016 11:45:25 -0700
>
>
>
>
> User-agent: 
>
> mu4e 0.9.17; emacs 25.1.50.2
>
>
>
>
> This patch adds a customizable variable cpp-message-min-time-interval to
> avoid over messaging.
>
> diff --git a/lisp/progmodes/cpp.el b/lisp/progmodes/cpp.el
> index 7d641ab47f09..1dd179d9103f 100644
> --- a/lisp/progmodes/cpp.el
> +++ b/lisp/progmodes/cpp.el
> @@ -104,6 +104,12 @@ cpp-edit-list
>                                (const :tag "Both branches writable" both))))
>    :group 'cpp)
>  
> +(defcustom cpp-message-min-time-interval 1
> +  "The minimum time interval in seconds that cpp-mode should
> +print messages.  No message will be printed if set to 0."
> +  :type 'integer
> +  :group 'cpp)
> +
>  (defvar cpp-overlay-list nil)
>  ;; List of cpp overlays active in the current buffer.
>  (make-variable-buffer-local 'cpp-overlay-list)
> @@ -278,7 +284,7 @@ cpp-highlight-buffer
>                           (cpp-parse-close from to))
>                          (t
>                           (cpp-parse-error "Parser error"))))))))
> -      (message "Parsing...done"))
> +      (cpp-progress-message "Parsing...done"))
>      (if cpp-state-stack
>        (save-excursion
>         (goto-char (nth 3 (car cpp-state-stack)))
> @@ -823,10 +829,10 @@ cpp-progress-time
>  ;; Last time we issued a progress message.
>  
>  (defun cpp-progress-message (&rest args)
> -  ;; Report progress at most once a second.  Take same ARGS as `message'.
> +  "Report progress at most once a second.  Take same ARGS as `message'."
>    (let ((time (nth 1 (current-time))))
> -    (if (= time cpp-progress-time)
> -       ()
> +    (when (>= (- time cpp-progress-time)
> +              cpp-message-min-time-interval)
>        (setq cpp-progress-time time)
>        (apply 'message args))))
>  
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#24861: [PATCH] Fix annoying "Parsing...done" message in c++-mode
>
>
>
>
> Date: 
>
> Fri, 25 Nov 2016 12:53:45 +0200
>
>
>
>
> > From: Hong Xu <address@hidden>
> > Cc: address@hidden
> > Date: Sat, 19 Nov 2016 16:20:10 -0800
> > 
> > Thanks, updated.
>
> Thanks, pushed to master.
>
>
> --- End Message ---