--- Begin Message ---
|
Subject: |
[PATCH] Add tests for lisp/kmacro.el |
|
Date: |
Sun, 13 Nov 2016 13:23:51 -0800 |
Hello,
There weren't any tests for kmacro.el, so I have written some.
Two things that may yet need to be done:
1. These tests make extensive use of two macros, called
kmacro-tests-should-call and kmacro-tests-should-not-call. They are
context-creating macros which add advice to named functions for the
duration of a test. I think that these two macros would be a useful
addition to ERT, and I'll submit that idea as a separate patch.
2. I found several minor bugs in the process of writing these, leading
to tests marked as :expected-result :failed. One is a way to create an
empty keyboard macro using the mouse and the rest are ways to get
kmacro-step-edit-macro to behave oddly. I haven't sent them to
bug-gnu-emacs yet. When I do so would it be better to send them
individually or put all the step-edit ones in one report?
My copyright assignment paperwork was finished as of Nov 2.
0001-Add-tests-for-lisp-kmacro.el.patch
Description: Text document
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#24939: [PATCH] Add tests for lisp/kmacro.el |
|
Date: |
Sat, 04 Feb 2017 13:57:16 +0200 |
> From: Gemini Lasswell <address@hidden>
> Cc: address@hidden
> Date: Sat, 31 Dec 2016 09:42:25 -0800
>
> Eli Zaretskii <address@hidden> writes:
> > Allow me a few comments to your proposed patch.
>
> Here is an updated version taking your comments into account. I was able
> to remove the use of advice on all the functions in macros.c except for
> end-kbd-macro, because I couldn't come up with another way to make
> kmacro-end-macro recognize a keyboard macro defined by a test.
> kmacro-end-macro tests last-kbd-macro right after it calls
> end-kbd-macro, and end-kbd-macro is going to leave last-kbd-macro empty
> unless it has something in current_kboard->kbd_macro_buffer, which Lisp
> can't access. If there is another strategy you'd like me to try there,
> let me know.
Thanks, I pushed this now.
> This patch contains kmacro-tests-with-message-capture which is the same
> as the macro proposed as an addition to ert-x.el in bug#25158, so if
> that patch is adopted, it could be removed from this patch.
I've replaced the macro with ert-with-message-capture.
--- End Message ---