--- Begin Message ---
|
Subject: |
25.1; Mistaken setup function in Turkish language environment |
|
Date: |
Thu, 16 Feb 2017 21:17:28 +0300 |
In ‘lisp/languages/european.el’, in the definition of the «Turkish»
language environment, there are two conses with the car
‘setup-function’, one of which have the cdr
‘turkish-case-conversion-enable’ and the other
‘turkish-case-conversion-disable’. The second one should have the car
‘exit-function’ instead. Below is a patch that fixes the bug. Note
that the patch does not include a NEWS entry, that's because I don't
know whether to put it in NEWS for 26 or 25.2 (I think the latter is
more likely). The news entry for this change might be «Fix bug
preventing application of Turkish case conversion rules in the "Turkish"
language environment.» I'll update the patch with a news entry if
requested. Reproduction is as follows:
- M-x set-language-environment RET Turkish RET
- Insert ‘iiıı’, upcase that string, you'll get ‘IIıı’, but should've
gotten ‘İİII’.
diff --git a/lisp/language/european.el b/lisp/language/european.el
index 954ac1f450..6c0232efd3 100644
--- a/lisp/language/european.el
+++ b/lisp/language/european.el
@@ -506,7 +506,7 @@ 'ibm437
(input-method . "turkish-postfix")
(sample-text . "Turkish (Türkçe) Merhaba")
(setup-function . turkish-case-conversion-enable)
- (setup-function . turkish-case-conversion-disable)
+ (exit-function . turkish-case-conversion-disable)
(documentation . "Support for Turkish.
Differs from the Latin-5 environment in using the `turkish-postfix' input
method and applying Turkish case rules for the characters i, I, ı, İ.")))
In GNU Emacs 25.1.3 (amd64-unknown-freebsd11.0, X toolkit, Xaw scroll bars)
of 2017-01-24 built on xi.bootis
Repository revision: f0eb70d8935be90f7c03e187c12d9b60e7214cc6
Windowing system distributor 'The X.Org Foundation', version 11.0.11704000
Configured using:
'configure --prefix=<user home directory (deduced)>/local -C
--enable-silent-rules
--disable-dependency-tracking --with-x-toolkit=athena --without-gpm
--without-dbus --without-gconf --without-gsettings --without-selinux
--with-modules --with-file-notification=yes --with-x'
Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND NOTIFY ACL GNUTLS LIBXML2
FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS LUCID X11 MODULES
Important settings:
value of $LC_MESSAGES: en_US.UTF-8
value of $LANG: tr_TR.UTF-8
locale-coding-system: utf-8-unix
Major mode: Lisp Interaction
Minor modes in effect:
diff-auto-refine-mode: t
show-paren-mode: t
auto-insert-mode: t
display-time-mode: t
change-cursor-mode: t
winner-mode: t
save-place-mode: t
auto-image-file-mode: t
persistent-scratch-autosave-mode: t
which-key-mode: t
global-paren-face-mode: t
paren-face-mode: t
eval-sexp-fu-flash-mode: t
highlight-parentheses-mode: t
paredit-mode: t
outline-minor-mode: t
global-gk-minor-mode: t
gk-minor-mode: t
gk-utf8-entry-mode: t
shell-dirtrack-mode: t
tooltip-mode: t
global-eldoc-mode: t
electric-quote-mode: t
mouse-wheel-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
size-indication-mode: t
line-number-mode: t
transient-mark-mode: t
Recent messages:
mouse-2, RET: find function's definition
mouse-2, RET: describe this symbol
t
Saving file <user home directory (deduced)>/co/emacs.d/gk/gk-turkish.el...
Wrote <user home directory (deduced)>/co/emacs.d/gk/gk-turkish.el
Mark set
Undo!
Quit
Making completion list...
Load-path shadows:
<user home directory (deduced)>/co/emacs.d/site/let-alist hides
<user home directory (deduced)>/local/share/emacs/25.1/lisp/emacs-lisp/let-alist
Features:
(shadow mailalias emacsbug gk-langenvs gk-turkish debug finder
finder-inf lisp-mnt package skeleton vc-hg dired-aux eieio-opt speedbar
sb-image ezimage dframe hl-line org-table diff-mode misearch
multi-isearch two-column iso-transl smiley gnus-cite mm-archive
mail-extr qp gnus-async gnus-bcklg gnus-ml disp-table pop3 nndraft nnmh
nnfolder nnml gnus-agent gnus-srvr gnus-score score-mode nnvirtual
gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime dig nntp
gnus-cache gnus-sum gnus-group gnus-undo gnus-start gnus-cloud nnimap
nnmail mail-source utf7 netrc nnoo gnus-spec gnus-int gnus-range
gnus-win network-stream nsm starttls url-http tls gnutls url-gw
url-cache url-auth org-id tabify org-colview diary-lib diary-loaddefs
cal-iso sort cal-move parse-time ffap vc-filewise org-rmail org-mhe
org-irc org-info org-gnus org-docview org-bibtex bibtex org-bbdb org-w3m
paren autoinsert init server gk bsdpkg pass-listing password-store
thinks boxquote gk-www gk-feeds gk-urls elfeed-csv elfeed-show elfeed-db
avl-tree elfeed-search elfeed elfeed-curl elfeed-lib elfeed-log
xml-query xml gk-vc diff vc-rcs vc-cvs vc vc-dispatcher log-edit
pcvs-util add-log gk-ui time ibuf-macs cursor-chg winner mono-theme
saveplace ibuffer-vc ibuf-ext ibuffer goto-addr apropos gk-system man
gk-multimedia image+ image-file persistent-scratch tramp-cache
gk-globals forecast solar cal-dst which-key smooth-scroll paren-face
gk-keys goto-last-change windmove gk-programming inf-ruby ruby-mode smie
js sgml-mode json map imenu cc-mode cc-fonts cc-guess cc-menus cc-cmds
cc-styles cc-align cc-engine cc-vars cc-defs slime-quicklisp
slime-xref-browser tree-widget slime-tramp tramp tramp-compat
tramp-loaddefs trampver slime-banner slime-asdf grep slime-mrepl
inferior-slime slime-fancy slime-trace-dialog slime-fontifying-fu
slime-package-fu slime-references slime-compiler-notes-tree
slime-scratch slime-presentations bridge slime-mdot-fu
slime-enclosing-context slime-fuzzy slime-fancy-trace
slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc
slime-repl slime-parse slime arc-mode archive-mode hyperspec thingatpt
scheme gk-outline eval-sexp-fu rx highlight inf-lisp
highlight-parentheses paredit gk-org ob-sh latexenc ox-odt rng-loc
rng-uri rng-parse rng-match rng-dt rng-util rng-pttrn nxml-parse nxml-ns
nxml-enc xmltok nxml-util ox-beamer ox-latex ox-icalendar ox-html
ox-ascii ox-publish ox org-element org-protocol org-mobile org-agenda
gk-org-cite gk-fonts gk-alist gk-mail smtpmail sendmail rmailsum rmail
message idna rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse
rfc2231 rfc2047 rfc2045 ietf-drums gmm-utils mailheader gk-utils
whole-line-or-region org org-macro org-footnote org-pcomplete org-list
org-faces org-entities noutline outline org-version ob-emacs-lisp ob
ob-tangle ob-ref ob-lob ob-table ob-exp org-src ob-keys ob-comint
ob-core ob-eval org-compat org-macs org-loaddefs find-func cal-menu
calendar cal-loaddefs etags xref project f dash s ucs-normalize epa-mail
epa derived epg epg-config bbdb-vcard bbdb-com crm mailabbrev vcard bbdb
bbdb-site timezone mairix gk-lingua gk-minor-mode ace-jump-mode
face-remap gk-file gk-mac gk-editing zencoding-mode cl ispell
writeroom-mode visual-fill-column lorem-ipsum gk-utf8 easy-mmode
gk-input-methods gk-unilat gk-syriac gk-greek gk-armenian quail
gk-global-modes eww mm-url gnus gnus-ems nnheader mail-utils url-queue
url url-proxy url-privacy url-expand url-methods url-history url-cookie
url-domsuf url-util url-parse auth-source cl-seq eieio eieio-core
cl-macs gnus-util mm-util help-fns mail-prsvr password-cache url-vars
mailcap shr seq byte-opt bytecomp byte-compile cl-extra help-mode cconv
dom browse-url diminish gk-edit rect gk-documents pdf-tools compile
cus-edit cus-start cus-load wid-edit pdf-view bookmark pp pdf-cache
pdf-info tq pdf-util advice doc-view subr-x jka-compr image-mode
gk-dired edmacro kmacro ls-lisp wdired image-dired format-spec dired-x
easymenu dired gk-crypt gk-comint shell pcomplete comint ansi-color ring
cl-loaddefs pcase cl-lib gv time-date mule-util tooltip eldoc electric
uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list newcomment elisp-mode lisp-mode prog-mode register page
menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core frame cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help
simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces
cus-face macroexp files text-properties overlay sha1 md5 base64 format
env code-pages mule custom widget hashtable-print-readable backquote
kqueue dynamic-setting font-render-setting x-toolkit x multi-tty
make-network-process emacs)
Memory information:
((conses 16 708057 112535)
(symbols 48 60750 0)
(miscs 40 3106 2391)
(strings 32 164867 18529)
(string-bytes 1 5591913)
(vectors 16 94097)
(vector-slots 8 2204328 85336)
(floats 8 3223 5712)
(intervals 56 11336 3326)
(buffers 976 78))
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#25763: 25.1; Mistaken setup function in Turkish language environment |
|
Date: |
Sat, 18 Feb 2017 13:20:24 +0200 |
> From: Göktuğ Kayaalp <address@hidden>
> Date: Thu, 16 Feb 2017 21:17:28 +0300
>
> In ‘lisp/languages/european.el’, in the definition of the «Turkish»
> language environment, there are two conses with the car
> ‘setup-function’, one of which have the cdr
> ‘turkish-case-conversion-enable’ and the other
> ‘turkish-case-conversion-disable’. The second one should have the car
> ‘exit-function’ instead. Below is a patch that fixes the bug.
Thanks, pushed to the master branch. (It was a typo made more than 10
years ago.)
> Note that the patch does not include a NEWS entry, that's because I
> don't know whether to put it in NEWS for 26 or 25.2 (I think the
> latter is more likely).
There's no need to prepare NEWS entries for bugfixes, we only mention
new features in NEWS.
--- End Message ---