[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#25751: closed (Query replace lazy highlighting)

From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#25751: closed (Query replace lazy highlighting)
Date: Tue, 21 Feb 2017 23:24:01 +0000

Your message dated Wed, 22 Feb 2017 01:22:30 +0200
with message-id <address@hidden>
and subject line Re: bug#25751: Query replace lazy highlighting
has caused the debbugs.gnu.org bug report #25751,
regarding Query replace lazy highlighting
to be marked as done.

(If you believe you have received this mail in error, please contact

25751: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=25751
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: Query replace lazy highlighting Date: Thu, 16 Feb 2017 14:18:31 +0100 User-agent: mu4e 0.9.17; emacs
(apologies if this has been posted before, but I can't find any

When query-replacing and confirming, matches get unhighlighted, and then
highlighted again, which is very distracting. E.g. open a file, M-% a ->
a, y, other matches of a get unhighlighted then highlighted again.

(setq lazy-highlight-initial-delay 0) (shouldn't it be default by the
way, at least on graphical displays?) reduces the problem but does not
eliminate it (it produces small flickers). There's
lazy-highlight-cleanup, but that disables cleanup completely, which I
don't want.

Can't this be eliminated?


--- End Message ---
--- Begin Message --- Subject: Re: bug#25751: Query replace lazy highlighting Date: Wed, 22 Feb 2017 01:22:30 +0200 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (x86_64-pc-linux-gnu)
>>> > I think the problem is not that we remove the highlight and add it
>>> > anew, the problem is that there's a redisplay cycle in between the
>>> > removal and the following addition.  The fact that setting
>>> > lazy-highlight-initial-delay alleviates the problem to some extent,
>>> > but still leaves the flicker tells me that there's a call to sit-for
>>> > or some such somewhere in the code that processes replacements, and
>>> > the removal and addition of the highlight are on two different sides
>>> > of that sit-for call.  One possible solution would be to remove the
>>> > highlight and add it without triggering redisplay, then I'd expect the
>>> > flicker to go away.
>>> >
>>> > Does this make sense?
>>> This feature is called _lazy_ highlighting where _lazy_ implies that it's
>>> intended to highlight matches much later after a lot of redisplay cycles.
>> You could still leave the "lazy" part, if you both remove and re-add
>> the overlays after the idle delay.  IOW, the important thing is not to
>> have redisplay between removal and addition of the highlight.
> That's an option too, and here is the tested patch (it sets
> lazy-highlight-max-at-a-time to nil to avoid redisplay between
> lazy iterations):

Installed and closed.

--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]