|
From: | GNU bug Tracking System |
Subject: | [debbugs-tracker] bug#25926: closed ([PATCH] gnu: pugixml: Build relocatable library.) |
Date: | Sat, 04 Mar 2017 23:04:02 +0000 |
Your message dated Sun, 5 Mar 2017 00:03:20 +0100 with message-id <address@hidden> and subject line Re: bug#25926: [PATCH] gnu: pugixml: Build relocatable library. has caused the debbugs.gnu.org bug report #25926, regarding [PATCH] gnu: pugixml: Build relocatable library. to be marked as done. (If you believe you have received this mail in error, please contact address@hidden) -- 25926: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=25926 GNU Bug Tracking System Contact address@hidden with problems
--- Begin Message ---Subject: [PATCH] gnu: pugixml: Build relocatable library. Date: Thu, 02 Mar 2017 01:00:35 +0100 User-agent: mu4e 0.9.18; emacs 25.1.1 Dear Guix, This patch modifies the recipe for pugixml to build a relocatable library. This fixes a compilation issue with Darktable. Kind regards, Roel Janssen >From 559b2c399f63beafe2d930cf75a71b7d575443cd Mon Sep 17 00:00:00 2001 From: Roel Janssen <address@hidden> Date: Thu, 2 Mar 2017 00:44:36 +0100 Subject: [PATCH] gnu: pugixml: Build relocatable library. * gnu/packages/xml.scm (pugixml): Add "-shared -fPIC" to ensure the library is relocatable. --- gnu/packages/xml.scm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gnu/packages/xml.scm b/gnu/packages/xml.scm index b91471690..30f49a8bd 100644 --- a/gnu/packages/xml.scm +++ b/gnu/packages/xml.scm @@ -752,7 +752,9 @@ the form of functions.") "0fcgggry5x5bn0zhb09ij9hb0p45nb0sv0d9fw3cm1cf62hp9n80")))) (build-system cmake-build-system) (arguments - `(#:tests? #f)) ; no tests + `(#:configure-flags '("-DCMAKE_CXX_FLAGS=-shared -fPIC" + "-DCMAKE_C_FLAGS=-shared -fPIC") + #:tests? #f)) ; no tests (home-page "http://pugixml.org") (synopsis "Light-weight, simple and fast XML parser for C++ with XPath support") (description -- 2.11.0
--- End Message ---
--- Begin Message ---Subject: Re: bug#25926: [PATCH] gnu: pugixml: Build relocatable library. Date: Sun, 5 Mar 2017 00:03:20 +0100 2017-03-04 23:26 GMT+01:00 Kei Kebreau <address@hidden>:LGTM. Pushed to master as 52c14bb6ec6fbd532b1e03a512d133Roel Janssen <address@hidden> writes:
> Dear Guix,
>
> This patch modifies the recipe for pugixml to build a relocatable
> library. This fixes a compilation issue with Darktable.
>
> Kind regards,
> Roel Janssen
>
>>>From 559b2c399f63beafe2d930cf75a71b7d575443cd Mon Sep 17 00:00:00 2001
> From: Roel Janssen <address@hidden>
> Date: Thu, 2 Mar 2017 00:44:36 +0100
> Subject: [PATCH] gnu: pugixml: Build relocatable library.
>
> * gnu/packages/xml.scm (pugixml): Add "-shared -fPIC" to ensure
> the library is relocatable.
> ---
> gnu/packages/xml.scm | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/xml.scm b/gnu/packages/xml.scm
> index b91471690..30f49a8bd 100644
> --- a/gnu/packages/xml.scm
> +++ b/gnu/packages/xml.scm
> @@ -752,7 +752,9 @@ the form of functions.")
> "0fcgggry5x5bn0zhb09ij9hb0p45nb 0sv0d9fw3cm1cf62hp9n80"))))
> (build-system cmake-build-system)
> (arguments
> - `(#:tests? #f)) ; no tests
> + `(#:configure-flags '("-DCMAKE_CXX_FLAGS=-shared -fPIC"
> + "-DCMAKE_C_FLAGS=-shared -fPIC")
> + #:tests? #f)) ; no tests
> (home-page "http://pugixml.org")
> (synopsis "Light-weight, simple and fast XML parser for C++ with XPath support")
> (description
e2499186b9.
so this is done too, right ?
--- End Message ---
[Prev in Thread] | Current Thread | [Next in Thread] |