[debbugs-tracker] bug#26546: closed ([PATCH] gnu: Add ponymix)

[GNU bug Tracking System]

Your message dated Mon, 17 Apr 2017 16:39:43 -0400
with message-id <address@hidden>
and subject line Re: bug#26546: [PATCH] gnu: Add ponymix
has caused the debbugs.gnu.org bug report #26546,
regarding [PATCH] gnu: Add ponymix
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
26546: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26546
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: Add ponymix
>
>
>
>
> Date: 
>
> Mon, 17 Apr 2017 21:41:22 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
>
>
>
>
> >From c0e4e33ba755803324e4ce8fbddb80e540d753af Mon Sep 17 00:00:00 2001
> From: Stefan Reichoer <address@hidden>
> Date: Mon, 17 Apr 2017 21:35:33 +0200
> Subject: [PATCH] gnu: Add ponymix.
>
> * gnu/packages/pulseaudio.scm (ponymix): New variable.
> ---
>  gnu/packages/pulseaudio.scm | 35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
>
> diff --git a/gnu/packages/pulseaudio.scm b/gnu/packages/pulseaudio.scm
> index 71fcc3f..c0602c3 100644
> --- a/gnu/packages/pulseaudio.scm
> +++ b/gnu/packages/pulseaudio.scm
> @@ -4,6 +4,7 @@
>  ;;; Copyright © 2016 Efraim Flashner <address@hidden>
>  ;;; Copyright © 2016 Ricardo Wurmus <address@hidden>
>  ;;; Copyright © 2017 Leo Famulari <address@hidden>
> +;;; Copyright © 2017 Stefan Reichör <address@hidden>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -247,3 +248,37 @@ sound server.")
>  graphical user interface to connect to a PulseAudio server and
>  easily control the volume of all clients, sinks, etc.")
>      (license l:gpl2+)))
> +
> +(define-public ponymix
> +  (package
> +    (name "ponymix")
> +    (version "5")
> +    (source (origin
> +             (method url-fetch)
> +             (uri (string-append "https://github.com/falconindy/ponymix/";
> +                                 "archive/" version ".tar.gz"))
> +             (sha256
> +              (base32
> +               "1c0ch98zry3c4ixywwynjid1n1nh4xl4l1p548giq2w3zwflaghn"))
> +              (modules '((guix build utils)))
> +              (snippet
> +               '(substitute* "Makefile"
> +                  (("/usr") "")))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:tests? #f ; There is no test suite.
> +       #:make-flags (let ((out (assoc-ref %outputs "out")))
> +                      (list (string-append "DESTDIR=" out)))
> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure)))) ; There's no configure phase.
> +    (inputs
> +     `(("pulseaudio" ,pulseaudio)))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (home-page "https://github.com/falconindy/ponymix";)
> +    (synopsis "CLI PulseAudio volume control")
> +    (description
> +     "PulseAudio Volume Control for the CLI. In addition it is possible
> +to use named sources and sinks.")
> +    (license l:expat)))
> -- 
> 2.7.4
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: bug#26546: [PATCH] gnu: Add ponymix Date: Mon, 17 Apr 2017 16:39:43 -0400 User-agent: Mutt/1.8.1 (2017-04-11)

On Mon, Apr 17, 2017 at 09:41:22PM +0200, Stefan Reichör wrote:
> From c0e4e33ba755803324e4ce8fbddb80e540d753af Mon Sep 17 00:00:00 2001
> From: Stefan Reichoer <address@hidden>
> Date: Mon, 17 Apr 2017 21:35:33 +0200
> Subject: [PATCH] gnu: Add ponymix.
> 
> * gnu/packages/pulseaudio.scm (ponymix): New variable.

Thanks! Pushed as 05bdb5e64dea826552510cfeba8c63bcf487dcad with the
following changes:

> +             (uri (string-append "https://github.com/falconindy/ponymix/";
> +                                 "archive/" version ".tar.gz"))

To satisfy `guix lint`, I used (file-name) to make sure the source
tarball included the name of the package.

> +              (modules '((guix build utils)))
> +              (snippet
> +               '(substitute* "Makefile"
> +                  (("/usr") "")))))

Since origin snippets affect what you get from `guix build --source`, we
reserve them for fixing serious bugs and software freedom issues.
Guix-specific changes like this one are done in build phases, which
don't affect the source tarball. So, I moved this substitution into a
'patch-paths' phase.

> +    (synopsis "CLI PulseAudio volume control")
> +    (description
> +     "PulseAudio Volume Control for the CLI. In addition it is possible
> +to use named sources and sinks.")

I made some stylistic changes here.

signature.asc
Description: PGP signature

--- End Message ---