[debbugs-tracker] bug#26549: closed ([PATCH] gnu: Add emacs-google-maps.)

[GNU bug Tracking System]

Your message dated Sun, 23 Apr 2017 19:25:20 -0400
with message-id <address@hidden>
and subject line Re: bug#26549: [PATCH] gnu: Add emacs-google-maps.
has caused the debbugs.gnu.org bug report #26549,
regarding [PATCH] gnu: Add emacs-google-maps.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
26549: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26549
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: Add emacs-google-maps.
>
>
>
>
> Date: 
>
> Tue, 18 Apr 2017 01:09:40 +0200
>
>
>
>
> * gnu/packages/emacs.scm (emacs-google-maps): New variable.
> ---
>  gnu/packages/emacs.scm | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 673bbdf89..95298a0fa 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -1229,6 +1229,25 @@ or XEmacs.")
>  the Emacs buffer.")
>      (license license:gpl3+)))
>  
> +(define-public emacs-google-maps
> +  (package
> +    (name "emacs-google-maps")
> +    (version "1.0.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://github.com/jd/google-maps.el/";
> +                                  "archive/" version ".tar.gz"))
> +              (file-name (string-append name "-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "014bxapm4d8vjxbzrfjdpsavxyfx981mlcb10aq5rmigr6il8ybs"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://github.com/jd/google-maps.el";)
> +    (synopsis "Access Google Maps from Emacs")
> +    (description "The @code{google-maps} package allows to display Google
> +Maps directly inside Emacs.")
> +    (license license:gpl1+)))
> +
>  (define-public emacs-mmm-mode
>    (package
>      (name "emacs-mmm-mode")
> -- 
> 2.11.0
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: bug#26549: [PATCH] gnu: Add emacs-google-maps. Date: Sun, 23 Apr 2017 19:25:20 -0400 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

Vasile Dumitrascu <address@hidden> writes:

>   Hi
>
> You were correct. Please find attached the updated patch. Thank you,
>
>   Vasile
>
> Alex Kost:
>> Kei Kebreau (2017-04-20 14:00 -0400) wrote:
>> 
>>> Vasile Dumitrascu <address@hidden> writes:
>>>
>>>> * gnu/packages/emacs.scm (emacs-google-maps): New variable.
>>>> ---
>>>>  gnu/packages/emacs.scm | 19 +++++++++++++++++++
>>>>  1 file changed, 19 insertions(+)
>>>>
>>>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>>>> index 673bbdf89..95298a0fa 100644
>>>> --- a/gnu/packages/emacs.scm
>>>> +++ b/gnu/packages/emacs.scm
>>>> @@ -1229,6 +1229,25 @@ or XEmacs.")
>>>>  the Emacs buffer.")
>>>>      (license license:gpl3+)))
>>>>  
>>>> +(define-public emacs-google-maps
>>>> +  (package
>>>> +    (name "emacs-google-maps")
>>>> +    (version "1.0.0")
>>>> +    (source (origin
>>>> +              (method url-fetch)
>>>> +              (uri (string-append "https://github.com/jd/google-maps.el/";
>>>> +                                  "archive/" version ".tar.gz"))
>>>> +              (file-name (string-append name "-" version ".tar.gz"))
>>>> +              (sha256
>>>> +               (base32
>>>> +                "014bxapm4d8vjxbzrfjdpsavxyfx981mlcb10aq5rmigr6il8ybs"))))
>>>> +    (build-system emacs-build-system)
>>>> +    (home-page "https://github.com/jd/google-maps.el";)
>>>> +    (synopsis "Access Google Maps from Emacs")
>>>> +    (description "The @code{google-maps} package allows to display Google
>>>> +Maps directly inside Emacs.")
>>>> +    (license license:gpl1+)))
>>>
>>> I can't seem to find this license mentioned anywhere, but maybe I'm just
>>> missing it. Where can I find it mentioned?
>> 
>> I think it should be gpl3+, as GPL3 or later is mentioned in the *.el files.
>> 
>>>> +
>>>>  (define-public emacs-mmm-mode
>>>>    (package
>>>>      (name "emacs-mmm-mode")
>>>
>>> Other than finding the license, this patch looks fine.
>> 
>> I agree.  Vasile, could you resend this patch please, I can't apply it
>> to the current master, not sure what the problem is.
>> 

Thanks! I've pushed this to master.

signature.asc
Description: PGP signature

--- End Message ---