[debbugs-tracker] bug#26294: closed ([PATCH] gnu: rocksdb: Disable tests on 32-bit systems.)

[GNU bug Tracking System]

Your message dated Fri, 12 May 2017 15:27:15 +0200
with message-id <address@hidden>
and subject line Re: bug#26294: [PATCH] gnu: rocksdb: Disable tests on 32-bit 
systems.
has caused the debbugs.gnu.org bug report #26294,
regarding [PATCH] gnu: rocksdb: Disable tests on 32-bit systems.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
26294: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26294
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: rocksdb: Disable tests on 32-bit systems.
>
>
>
>
> Date: 
>
> Wed, 29 Mar 2017 11:42:20 +0200
>
>
>
>
> * gnu/packages/databases.scm (rocksdb)[arguments]: Make #:tests? conditional.
> Delete unnecessary 'build' phase.
> ---
>  gnu/packages/databases.scm | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
> index b87e8a210..e73635910 100644
> --- a/gnu/packages/databases.scm
> +++ b/gnu/packages/databases.scm
> @@ -533,12 +533,20 @@ types are supported, as is encryption.")
>                    #t))))
>      (build-system gnu-build-system)
>      (arguments
> -     '(#:make-flags (list "CC=gcc"
> +     `(#:make-flags (list "CC=gcc"
>                            ;; Make the resulting library position-independent 
> so the
>                            ;; static version can be included in shared objects.
>                            "EXTRA_CXXFLAGS=-fPIC"
>                            (string-append "INSTALL_PATH="
>                                           (assoc-ref %outputs "out")))
> +       ;; Many tests fail on 32-bit platforms. There are multiple reports about
> +       ;; this upstream, but it's not going to be supported any time soon.
> +       #:tests? (let ((system ,(or (%current-target-system)
> +                                   (%current-system)))
> +                      (supported-systems '("x86_64-linux" "aarch64-linux")))
> +                  (if (member system supported-systems)
> +                      #t
> +                      #f))
>         #:phases
>         (modify-phases %standard-phases
>           (add-after 'unpack 'patch-Makefile
> @@ -548,6 +556,8 @@ types are supported, as is encryption.")
>                 (("#!/bin/sh") (string-append "#!" (which "sh"))))
>               #t))
>           (delete 'configure)
> +         ;; The default target is only needed for tests and built on demand.
> +         (delete 'build)
>           (add-before 'check 'disable-failing-tests
>             (lambda _
>               (substitute* "Makefile"
> -- 
> 2.12.2
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: bug#26294: [PATCH] gnu: rocksdb: Disable tests on 32-bit systems. Date: Fri, 12 May 2017 15:27:15 +0200 User-agent: Notmuch/0.24.1 (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu)

Marius Bakke <address@hidden> writes:

> Ludovic Courtès <address@hidden> writes:
>
>> Hello,
>>
>> Marius Bakke <address@hidden> skribis:
>>
>>> * gnu/packages/databases.scm (rocksdb)[arguments]: Make #:tests? 
>>> conditional.
>>> Delete unnecessary 'build' phase.
>>> ---
>>>  gnu/packages/databases.scm | 12 +++++++++++-
>>>  1 file changed, 11 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
>>> index b87e8a210..e73635910 100644
>>> --- a/gnu/packages/databases.scm
>>> +++ b/gnu/packages/databases.scm
>>> @@ -533,12 +533,20 @@ types are supported, as is encryption.")
>>>                    #t))))
>>>      (build-system gnu-build-system)
>>>      (arguments
>>> -     '(#:make-flags (list "CC=gcc"
>>> +     `(#:make-flags (list "CC=gcc"
>>>                            ;; Make the resulting library 
>>> position-independent so the
>>>                            ;; static version can be included in shared 
>>> objects.
>>>                            "EXTRA_CXXFLAGS=-fPIC"
>>>                            (string-append "INSTALL_PATH="
>>>                                           (assoc-ref %outputs "out")))
>>> +       ;; Many tests fail on 32-bit platforms. There are multiple reports 
>>> about
>>> +       ;; this upstream, but it's not going to be supported any time soon.
>>> +       #:tests? (let ((system ,(or (%current-target-system)
>>> +                                   (%current-system)))
>>> +                      (supported-systems '("x86_64-linux" 
>>> "aarch64-linux")))
>>> +                  (if (member system supported-systems)
>>> +                      #t
>>> +                      #f))
>>
>> This doesn’t work because (%current-target-system) is a GNU triplet,
>> like “arm-linux-gnueabihf”, whereas (%current-system) is a “system
>> type”, like “armhf-linux”.
>>
>> Instead you should use ‘string-prefix?’ or similar.
>>
>> Other than that, I think it should go in!
>
> Well, I actually tried this recently (also disabling the individual
> tests, which was a rabbit hole that ultimately gave an inexplicable
> error).
>
> Anyway, when building for i686-linux on x86_64, the compiler appears to
> hit a never-ending loop at the linking stage! I'm pretty sure this was
> not the case before the core-updates merge (when I tested this), so I
> wonder if it's a case of
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=26497 .
>
> To be continued, but now it would just cause the build to take up a CPU
> core until it times out, rather than failing early..

I'm still hitting some loop when building for i686-linux, but decided to
push this patch regardless to see if it works better on native platforms
(especially ARM, now that jemalloc is fixed).

Closing this bug, but will keep an eye on Hydra and open a new bug if
the build farm encounters the same problem.

signature.asc
Description: PGP signature

--- End Message ---