[debbugs-tracker] bug#27073: closed ([PATCH] gnu: Add cpuid.)

[GNU bug Tracking System]

Your message dated Thu, 25 May 2017 21:41:00 +0200
with message-id <address@hidden>
and subject line Re: bug#27073: [PATCH] gnu: Add cpuid.
has caused the debbugs.gnu.org bug report #27073,
regarding [PATCH] gnu: Add cpuid.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
27073: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=27073
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: Add cpuid.
>
>
>
>
> Date: 
>
> Thu, 25 May 2017 20:23:49 +0200
>
>
>
>
> * gnu/packages/linux.scm (cpuid): New variable.
> ---
>  gnu/packages/linux.scm | 35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
>
> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index 2e984dd42..d888ec2bb 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -23,6 +23,7 @@
>  ;;; Copyright © 2017 José Miguel Sánchez García <address@hidden>
>  ;;; Copyright © 2017 Gábor Boskovits <address@hidden>
>  ;;; Copyright © 2017 Mathieu Othacehe <address@hidden>
> +;;; Copyright © 2017 Clément Lassieur <address@hidden>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -3948,3 +3949,37 @@ available in the kernel Linux.")
>                     #t))))))
>         ((#:allowed-references _ '("out"))
>          '("out"))))))
> +
> +(define-public cpuid
> +  (package
> +    (name "cpuid")
> +    (version "20170122")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "http://www.etallen.com/cpuid/cpuid-";
> +                                  version ".src.tar.gz"))
> +              (sha256
> +               (base32
> +                "0ra8ph9m1dckqaikfnbsh408fp2w9k49fkl423fl2hvhwsm14xk6"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     '(#:make-flags '("CC=gcc")
> +       #:tests? #f ; no tests
> +       #:phases (modify-phases %standard-phases
> +                  (delete 'configure)
> +                  (add-before 'install 'fix-makefile
> +                    (lambda* (#:key outputs #:allow-other-keys)
> +                      (substitute* "Makefile"
> +                        (("\\$\\(BUILDROOT\\)/usr") (assoc-ref outputs "out")))
> +                      (substitute* "Makefile"
> +                        (("-m 444") "-m 644"))
> +                      #t)))))
> +    (inputs `(("perl" ,perl)))
> +    (supported-systems '("i686-linux" "x86_64-linux"))
> +    (home-page "http://etallen.com/cpuid.html";)
> +    (synopsis "Linux tool to dump x86 CPUID information about the CPU(s)")
> +    (description "cpuid dumps detailed information about the CPU(s) gathered
> +from the CPUID instruction, and also determines the exact model of CPU(s).  It
> +supports Intel, AMD, and VIA CPUs, as well as older Transmeta, Cyrix, UMC,
> +NexGen, Rise, and SiS CPUs.")
> +    (license license:gpl2+)))
> -- 
> 2.13.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#27073: [PATCH] gnu: Add cpuid.
>
>
>
>
> Date: 
>
> Thu, 25 May 2017 21:41:00 +0200
>
>
>
>
> User-agent: 
>
> mu4e 0.9.18; emacs 25.2.1
>
>
>
>
> Marius Bakke <address@hidden> writes:
>
> > Clément Lassieur <address@hidden> writes:
> >
> >> * gnu/packages/linux.scm (cpuid): New variable.
> >
> > [...]
> >
> >> +       #:phases (modify-phases %standard-phases
> >> +                  (delete 'configure)
> >> +                  (add-before 'install 'fix-makefile
> >> +                    (lambda* (#:key outputs #:allow-other-keys)
> >> +                      (substitute* "Makefile"
> >> +                        (("\\$\\(BUILDROOT\\)/usr") (assoc-ref outputs 
> >> "out")))
> >> +                      (substitute* "Makefile"
> >> +                        (("-m 444") "-m 644"))
> >
> > Why is this necessary? Perhaps you can add a comment?
>
> I added:
>
> ;; Make the compressed manpages writable so that the
> ;; reset-gzip-timestamps phase does not error out.
>
> > LGTM otherwise.
>
> Thanks for the review :-) Pushed.
>
>
> --- End Message ---