[debbugs-tracker] bug#27597: closed ([PATCH] fix warnings in src/xdisp.c)

[GNU bug Tracking System]

Your message dated Sat, 08 Jul 2017 11:19:32 +0300
with message-id <address@hidden>
and subject line Re: bug#27597: [PATCH] fix warnings in src/xdisp.c
has caused the debbugs.gnu.org bug report #27597,
regarding [PATCH] fix warnings in src/xdisp.c
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
27597: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=27597
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] fix warnings in src/xdisp.c Date: Thu, 6 Jul 2017 17:47:03 +0600

Hello,

here is simple fix for following warnings:

xdisp.c: In function ‘Fdump_glyph_matrix’:
xdisp.c:19320:20: error: format ‘%lld’ expects argument of type ‘long
long int’, but argument 3 has type ‘ptrdiff_t {aka long int}’
[-Werror=format=]
   fprintf (stderr, "PT = %"pI"d, BEGV = %"pI"d. ZV = %"pI"d\n",

from src/xdisp.c

0001-use-pD-directives-for-ptrdiff_t-values-to-get-rid-fr.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#27597: [PATCH] fix warnings in src/xdisp.c
>
>
>
>
> Date: 
>
> Sat, 08 Jul 2017 11:19:32 +0300
>
>
>
>
> > From: Alexander Kuleshov <address@hidden>
> > Date: Thu, 6 Jul 2017 17:47:03 +0600
> > 
> > here is simple fix for following warnings:
> > 
> > xdisp.c: In function ‘Fdump_glyph_matrix’:
> > xdisp.c:19320:20: error: format ‘%lld’ expects argument of type ‘long
> > long int’, but argument 3 has type ‘ptrdiff_t {aka long int}’
> > [-Werror=format=]
> >    fprintf (stderr, "PT = %"pI"d, BEGV = %"pI"d. ZV = %"pI"d\n",
> > 
> > from src/xdisp.c
>
> Thanks, pushed to master.
>
> In the future, please provide a commit log message that is according
> to our coding standards:
>
>  . mention the names of functions in which you make changes
>  . start sentences with a capital letter
>  . mention the bug number
>
> Here's the log message I used in this case:
>
>         * src/xdisp.c (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
>         Use pD directives for ptrdiff_t values instead of pI, to avoid
>         compilation warnings on 64-bit hosts.  (Bug#27597)
>
>
>
> --- End Message ---