--- Begin Message ---
|
Subject: |
25.2; cc-mode doesn't use prog-mode-map as parent for c-mode-base-map |
|
Date: |
Tue, 25 Apr 2017 20:52:45 +0200 (CEST) |
See title. Modes derived from cc-mode inherit its keybindings, however
they won't inherit keys defined in prog-mode-map. This could probably
be rectified by using (set-keymap-parent c-mode-base-map prog-mode-map)
at the strategically correct location (like the lengthy top-level if
form setting up that map). Is there any reason to *not* have this
change? I'd otherwise write a patch for it.
In GNU Emacs 25.2.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.22.10)
of 2017-04-22 built on juergen
Windowing system distributor 'The X.Org Foundation', version 11.0.11903000
Configured using:
'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib
--localstatedir=/var --with-x-toolkit=gtk3 --with-xft --with-modules
'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe
-fstack-protector-strong' CPPFLAGS=-D_FORTIFY_SOURCE=2
LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro'
Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS
NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11 MODULES
Important settings:
value of $LANG: en_US.UTF-8
locale-coding-system: utf-8-unix
Major mode: Lisp Interaction
Minor modes in effect:
tooltip-mode: t
global-eldoc-mode: t
electric-indent-mode: t
mouse-wheel-mode: t
tool-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
transient-mark-mode: t
Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Load-path shadows:
None found.
Features:
(shadow sort mail-extr emacsbug message dired format-spec rfc822 mml
mml-sec password-cache epg epg-config gnus-util mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail
rfc2047 rfc2045 ietf-drums mm-util help-fns help-mode easymenu
cl-loaddefs pcase cl-lib mail-prsvr mail-utils time-date mule-util
tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt
fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register
page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock
font-lock syntax facemenu font-core frame cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese charscript case-table epa-hook
jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice
loaddefs button faces cus-face macroexp files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote dbusbind inotify dynamic-setting
system-font-setting font-render-setting move-toolbar gtk x-toolkit x
multi-tty make-network-process emacs)
Memory information:
((conses 16 86143 6257)
(symbols 48 19774 0)
(miscs 40 45 146)
(strings 32 14298 4240)
(string-bytes 1 408381)
(vectors 16 11746)
(vector-slots 8 430626 5147)
(floats 8 166 174)
(intervals 56 205 0)
(buffers 976 18))
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#26658: 25.2; cc-mode doesn't use prog-mode-map as parent for c-mode-base-map |
|
Date: |
Wed, 12 Jul 2017 17:50:03 +0000 |
|
User-agent: |
Mutt/1.7.2 (2016-11-26) |
Hello, Vasilij.
On Sun, May 07, 2017 at 15:58:34 +0200, Vasilij Schneidermann wrote:
[ .... ]
> > Do you have commit access to the Emacs repository?
> No and I doubt I'll ever get it because I don't understand the commit
> message rules at all. They appear to be loosely based upon GNU
> changelog guidelines, but with everyone I send patches to interpreting
> them differently, probably because there isn't much substance to them in
> the first place. I've resorted to using M-x add-change-log-entry,
> copying the result into the commit message and adjusting it describing
> my changes, but there's apparently more to it than that.
I've committed your patch, slightly altered, and am closing the bug. I
suspect that the commit message I used will be yet another variant. ;-(
Thanks again for that patch.
> Anyway, here's an updated patch.
> >>From 1e4a92e05b78edb2f58c138aa7792d39a6d9a9cb Mon Sep 17 00:00:00 2001
> From: Vasilij Schneidermann <address@hidden>
> Date: Sun, 7 May 2017 15:55:49 +0200
> Subject: [PATCH] Make prog-mode-map the parent of c-mode-base-map
> Fixes #26658.
> * lisp/progmodes/cc-mode.el (c-mode-base-map): Make prog-mode-map the
> parent of c-mode-map if possible.
> ---
> lisp/progmodes/cc-mode.el | 3 +++
> 1 file changed, 3 insertions(+)
> diff --git a/lisp/progmodes/cc-mode.el b/lisp/progmodes/cc-mode.el
> index 20c63d4dbe..8f9e40bb0d 100644
> --- a/lisp/progmodes/cc-mode.el
> +++ b/lisp/progmodes/cc-mode.el
> @@ -276,6 +276,9 @@ c-bind-special-erase-keys
> nil
> (setq c-mode-base-map (make-sparse-keymap))
> + (when (and (cc-bytecomp-fboundp 'set-keymap-parent)
> + (boundp 'prog-mode-map))
> + (set-keymap-parent c-mode-base-map prog-mode-map))
> ;; Separate M-BS from C-M-h. The former should remain
> ;; backward-kill-word.
> --
> 2.12.2
--
Alan Mackenzie (Nuremberg, Germany).
--- End Message ---