--- Begin Message ---
|
Subject: |
slf4j-api: enable tests |
|
Date: |
Sun, 27 Aug 2017 13:31:42 +0200 |
Hi,
I found what prevented the tests to pass in slf4j-api. In
slf4j-api/pom.xml, the jar file is created with all classes, except
those in impl/.
I did the same with a new pase where I delete the impl/ directory and
regenerate the jar file. Maybe I should fix teh build.xml file instead?
Then, tests pass except for one file. This file is an abstract class
meant to be extended by other test cases, but it's not a test case in
itself, hence the failure. This time, I implemented another phase where
I fix the build.xml file to exclude this file from testing.
I'm working on other packages, and it's not the first time I see some
tests I need to disable because they shouldn't be run. Maybe I could
add arguments to the ant build system, such as #:test-include and
#:test-exclude, defaulting to '("**/*.java") and '() respectively?
Thank you :)
0001-gnu-java-slf4j-api-Fix-tests.patch
Description: Text Data
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: [bug#28250] slf4j-api: enable tests |
|
Date: |
Fri, 8 Sep 2017 20:42:42 +0200 |
Le Fri, 08 Sep 2017 18:05:25 +0200,
address@hidden (Ludovic Courtès) a écrit :
> Julien Lepiller <address@hidden> skribis:
>
> >>From 2a9b0420c249b4b896f5980a55be8ae5595bd96b Mon Sep 17 00:00:00
> >>2001
> > From: Julien Lepiller <address@hidden>
> > Date: Sun, 27 Aug 2017 13:19:31 +0200
> > Subject: [PATCH] gnu: java-slf4j-api: Fix tests.
> >
> > * gnu/packages/java.scm (java-slf4j-api)[arguments]: Enable tests
> > Adjust the jar content to prevent a test failure.
>
> I don’t fully understand what’s at play but this looks like a step in
> the right direction to me, so I’d say go ahead!
>
> Thanks,
> Ludo’.
Actually, since there was no answer on this bug, I already pushed it a
few days ago. I forgot to close the ticket.
Pushed as dcf7a8a660554eb952e6412637e26bb523af03e8.
--- End Message ---