[debbugs-tracker] bug#28515: closed ([PATCH] fix url-current-object is undefined)

[GNU bug Tracking System]

Your message dated Sat, 30 Sep 2017 16:35:30 +0300
with message-id <address@hidden>
and subject line Re: bug#28515:
has caused the debbugs.gnu.org bug report #28515,
regarding [PATCH] fix url-current-object is undefined
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
28515: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28515
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] fix url-current-object is undefined
>
>
>
>
> Date: 
>
> Tue, 19 Sep 2017 22:39:53 +0900
>
>
>
>
> `url-http-find-free-connection` using `url-current-object`, but this
> variable is nil at this point.
> ---
>  lisp/url/url-http.el | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el
> index 9e8c58b1cd..078106fb8d 100644
> --- a/lisp/url/url-http.el
> +++ b/lisp/url/url-http.el
> @@ -1249,9 +1249,10 @@ The return value of this function is the retrieval 
> buffer."
>          (nsm-noninteractive (or url-request-noninteractive
>                                  (and (boundp 'url-http-noninteractive)
>                                       url-http-noninteractive)))
> -         (connection (url-http-find-free-connection (url-host url)
> -                                                    (url-port url)
> -                                                    gateway-method))
> +         (connection (let ((url-current-object url))
> +                       (url-http-find-free-connection (url-host url)
> +                                                      (url-port url)
> +                                                      gateway-method)))
>           (mime-accept-string url-mime-accept-string)
>          (buffer (or retry-buffer
>                      (generate-new-buffer
> --
> 2.14.1
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#28515:
>
>
>
>
> Date: 
>
> Sat, 30 Sep 2017 16:35:30 +0300
>
>
>
>
> > From: 南 優也 <address@hidden>
> > Date: Mon, 25 Sep 2017 07:20:27 +0000 (GMT)
> > 
> > additional information:
> > `url-http` calls `url-http-find-free-connection` before `(setq 
> > url-current-object url)` and `url-http-find-free-connection` calls 
> > `url-open-stream` and `url-open-stream` referencing `url-current-object` 
> > before `url-http` updates it's value.
> > when `url-open-stream` referencing `url-current-object`, it's value is `nil` 
> > or old `url-current-object`.
> > 
> > so, let `url-current-object` to `url` in `url-http` before calling 
> > `url-http-find-free-connection`.
>
> Thanks, I fixed this on the emacs-26 branch.
>
>
> --- End Message ---