[debbugs-tracker] bug#27596: closed ([PATCH] guix: lint: Add checker for new upstream versions.)

[GNU bug Tracking System]

Your message dated Mon, 9 Oct 2017 14:17:54 +0300
with message-id <address@hidden>
and subject line Re: [bug#27596] [PATCH] guix: lint: Add checker for new 
upstream versions.
has caused the debbugs.gnu.org bug report #27596,
regarding [PATCH] guix: lint: Add checker for new upstream versions.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
27596: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=27596
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] guix: lint: Add checker for new upstream versions.
>
>
>
>
> Date: 
>
> Thu,  6 Jul 2017 13:17:23 +0300
>
>
>
>
> * guix/scripts/lint.scm (check-for-updates): New procedure.
> (%checkers): Add it.
> ---
>  guix/scripts/lint.scm | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm
> index 04ab85299..665db158c 100644
> --- a/guix/scripts/lint.scm
> +++ b/guix/scripts/lint.scm
> @@ -35,6 +35,7 @@
>    #:use-module (guix utils)
>    #:use-module (guix memoization)
>    #:use-module (guix scripts)
> +  #:use-module (guix scripts refresh)
>    #:use-module (guix gnu-maintenance)
>    #:use-module (guix monads)
>    #:use-module (guix cve)
> @@ -72,6 +73,7 @@
>              check-mirror-url
>              check-license
>              check-vulnerabilities
> +            check-for-updates
>              check-formatting
>              run-checkers
>  
> @@ -821,6 +823,10 @@ from ~s: ~a (~s)~%")
>                                   (string-join (map vulnerability-id unpatched)
>                                                ", ")))))))))
>  
> +(define (check-for-updates package)
> +  "Check if there is an update available for PACKAGE."
> +  (guix-refresh (package-name package)))
> +
>  
>  ;;;
>  ;;; Source code formatting.
> @@ -972,6 +978,10 @@ or a list thereof")
>   (CVE) database")
>       (check       check-vulnerabilities))
>     (lint-checker
> +     (name        'refresh)
> +     (description "Check the package for new upstream releases")
> +     (check       check-for-updates))
> +   (lint-checker
>       (name        'formatting)
>       (description "Look for formatting issues in the source")
>       (check       check-formatting))))
> -- 
> 2.13.2
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#27596] [PATCH] guix: lint: Add checker for new upstream versions. Date: Mon, 9 Oct 2017 14:17:54 +0300 User-agent: Mutt/1.8.3 (2017-05-23)

On Mon, Oct 09, 2017 at 09:28:04AM +0200, Ludovic Courtès wrote:
> Hello!
> 
> Efraim Flashner <address@hidden> skribis:
> 
> > On Sat, Oct 07, 2017 at 10:50:21PM +0200, Ludovic Courtès wrote:
> 
> [...]
> 
> >> >> +(define (check-for-updates package)
> >> >> +  "Check if there is an update available for PACKAGE."
> >> >> +  (match (package-latest-release package (force %updaters))
> >> >> +    ((? upstream-source? source)
> >> >> +     (when (version>? (upstream-source-version source)
> >> >> +                      (package-version package))
> >> >> +       (emit-warning package
> >> >> +                     (format #f (G_ "can be upgraded to ~a~%")
> >> >> +                             (upstream-source-version source)))))))
> >> >
> >> > I think you can (1) use ‘package-latest-release*’ which ensures that the
> >> > returned version is newer, and (2) add a case for #f since
> >> > ‘package-latest-release*’ can return #f.
> >> >
> >> > Apart from that it LGTM, thank you!
> >> >
> >> > Ludo’.
> >
> > I've been working on it with package-latest-release*, and its nice not
> > having to reimplement the logic, but I can't get it to return the newest
> > version of the upstream-package. I got it to return a useful message
> > with:
> >
> > (define (check-for-updates package)
> >   (if (package-latest-release* package (force %updaters))
> >        (emit-warning package
> >                      (format #f (G_ "can be upgraded to ~a~%")
> >                              (upstream-source-version 
> > (package-latest-release package (force %updaters)))))
> >        #t))
> >
> > but I've already checked if there's an upstream release, I shouldn't
> > need to check a second time. package-latest-release* returns true/false,
> 
> 
> AFAICS ‘package-latest-release*’ returns #f or an <upstream-source>:
> 
> --8<---------------cut here---------------start------------->8---
> scheme@(guile-user)> (package-latest-release* binutils (force %updaters))
> $4 = #<<upstream-source> package: "binutils" version: "2.29.1" urls: 
> ("mirror://gnu/binutils/binutils-2.29.1.tar.gz" 
> "mirror://gnu/binutils/binutils-2.29.1.tar.lz" 
> "mirror://gnu/binutils/binutils-2.29.1.tar.bz2" 
> "mirror://gnu/binutils/binutils-2.29.1.tar.xz") signature-urls: 
> ("mirror://gnu/binutils/binutils-2.29.1.tar.gz.sig" 
> "mirror://gnu/binutils/binutils-2.29.1.tar.lz.sig" 
> "mirror://gnu/binutils/binutils-2.29.1.tar.bz2.sig" 
> "mirror://gnu/binutils/binutils-2.29.1.tar.xz.sig")>
> --8<---------------cut here---------------end--------------->8---
> 
> So you can write:
> 
>   (match (package-latest-release* package (force %updaters))
>     ((? upstream-source? source)
>      …)
>     (#f   ;cannot determine latest release
>      #f))
> 
> HTH!
> 
> Ludo’.

I looked at the final diff between my earlier patch and my final
version, it pretty much added up to the lines you wrote above ;) I
should get myself a rubber duck, should help my debugging and reading
skills.


-- 
Efraim Flashner   <address@hidden>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

signature.asc
Description: PGP signature

--- End Message ---