--- Begin Message ---
|
Subject: |
[PATCH] gnu: acl: Enable tests. |
|
Date: |
Sat, 24 Jun 2017 14:06:06 -0400 |
* gnu/packages/acl.scm (acl)[arguments]: Enable tests. Add 'patch-tests' phase.
---
gnu/packages/acl.scm | 23 +++++++++++++++++------
1 file changed, 17 insertions(+), 6 deletions(-)
diff --git a/gnu/packages/acl.scm b/gnu/packages/acl.scm
index ae6764993..34f8c294a 100644
--- a/gnu/packages/acl.scm
+++ b/gnu/packages/acl.scm
@@ -44,19 +44,30 @@
(patches (search-patches "acl-hurd-path-max.patch"))))
(build-system gnu-build-system)
(arguments
- `(#:tests? #f ; FIXME: Investigate test suite failures
- #:test-target "tests"
+ `(#:test-target "tests"
#:phases
(alist-cons-after
'build 'patch-exec-bin-sh
(lambda _
(substitute* "test/run"
(("/bin/sh") (which "sh"))))
- (alist-replace
- 'install
+ (alist-cons-before
+ 'check 'patch-tests
(lambda _
- (zero? (system* "make" "install" "install-lib" "install-dev")))
- %standard-phases))))
+ ;; The coreutils do not have an ACL bit to remove from their
+ ;; output, so the sed expression that removes the bit is disabled.
+ (substitute* "test/sbits-restore.test"
+ (("\\| sed.*'") ""))
+ ;; These tests require the existence of a user named "bin", but
+ ;; this user does not exist within Guix's build environment.
+ (for-each (lambda (file)
+ (delete-file (string-append "test/" file)))
+ '("setfacl-X.test" "cp.test" "misc.test")))
+ (alist-replace
+ 'install
+ (lambda _
+ (zero? (system* "make" "install" "install-lib" "install-dev")))
+ %standard-phases)))))
(inputs `(("attr" ,attr)))
(native-inputs
`(("gettext" ,gettext-minimal)
--
2.13.1
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: [bug#27477] [PATCH] gnu: acl: Enable tests. |
|
Date: |
Sat, 4 Nov 2017 10:52:33 -0400 |
|
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Thu, Sep 14, 2017 at 09:46:33AM -0400, Kei Kebreau wrote:
> address@hidden (Ludovic Courtès) writes:
>
> > Kei Kebreau <address@hidden> skribis:
> >
> >> Leo Famulari <address@hidden> writes:
> >>
> >>> On Sat, Jun 24, 2017 at 02:06:06PM -0400, Kei Kebreau wrote:
> >>>> * gnu/packages/acl.scm (acl)[arguments]: Enable tests. Add
> >>>> 'patch-tests' phase.
> >>>
> >>> Great!
> >>>
> >>> But we'll probably need to wait for the next core-updates cycle. I've
> >>> applied to locally to a core-updates-next branch but it would be great
> >>> if you kept it around for the next cycle :)
> >>
> >> Cool. I'll hold on to the patch!
> >
> > Now is the time to try the patch on ‘core-updates’!
> >
> > Ludo’.
>
> Aw, I missed this becuase of my email migration. I'll catch it next time
> as long as this message makes it to address@hidden instead of
> address@hidden
>
> Thanks in advance.
I amended this patch to apply and pushed it as
2d433b5363fecba0d63caa1844c937dec4ccc23b.
signature.asc
Description: PGP signature
--- End Message ---