emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#29181: closed ([PATCH core-updates 0/1] Shrink Mes


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#29181: closed ([PATCH core-updates 0/1] Shrink Mesa)
Date: Wed, 08 Nov 2017 08:28:01 +0000

Your message dated Wed, 08 Nov 2017 09:27:29 +0100
with message-id <address@hidden>
and subject line Re: [bug#29181] [PATCH 1/1] gnu: mesa: Use symlinks instead of 
hard links.
has caused the debbugs.gnu.org bug report #29181,
regarding [PATCH core-updates 0/1] Shrink Mesa
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
29181: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29181
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: [PATCH core-updates 0/1] Shrink Mesa Date: Mon, 6 Nov 2017 22:40:57 +0100
Hello Guix!

This patch divides the nar size of ‘mesa’ (as reported by ‘guix size’)
almost by a factor of four.  It does so by replacing hard links created
upon “make install” with symlinks.

The new post-install phase prints things like:

--8<---------------cut here---------------start------------->8---
starting phase `symlinks-instead-of-hard-links'
creating 7 symlinks to 
'/gnu/store/l1iwgjgp88snlzp9nafdpd0vvsqv7lsi-mesa-17.2.1/lib/dri/i915_dri.so'
creating 3 symlinks to 
'/gnu/store/l1iwgjgp88snlzp9nafdpd0vvsqv7lsi-mesa-17.2.1/lib/dri/i965_dri.so'
creating 1 symlinks to 
'/gnu/store/l1iwgjgp88snlzp9nafdpd0vvsqv7lsi-mesa-17.2.1/lib/dri/nouveau_drv_video.so'
creating 1 symlinks to 
'/gnu/store/l1iwgjgp88snlzp9nafdpd0vvsqv7lsi-mesa-17.2.1/lib/libXvMCnouveau.so.1.0.0'
creating 2 symlinks to 
'/gnu/store/l1iwgjgp88snlzp9nafdpd0vvsqv7lsi-mesa-17.2.1/lib/vdpau/libvdpau_nouveau.so.1.0.0'
phase `symlinks-instead-of-hard-links' succeeded after 0.0 seconds
--8<---------------cut here---------------end--------------->8---

The nar size does not reflect disk usage since deduplication would
recreate the hard links anyway, but it reflects how much we have to
transfer over the wire since the nar format does not represent hard
links.  A similar problem arose with Git a while back, see
<https://bugs.gnu.org/21949>.

I’d like to push to ‘core-updates’.

Thoughts?

Ludo’.

Ludovic Courtès (1):
  gnu: mesa: Use symlinks instead of hard links.

 gnu/packages/gl.scm | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

-- 
2.14.2




--- End Message ---
--- Begin Message --- Subject: Re: [bug#29181] [PATCH 1/1] gnu: mesa: Use symlinks instead of hard links. Date: Wed, 08 Nov 2017 09:27:29 +0100 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)
Hi,

Marius Bakke <address@hidden> skribis:

> Ludovic Courtès <address@hidden> writes:
>
>> This reduces the nar size (as shown by 'guix size') by 124 MiB, from
>> 169 MiB to 45 MiB (almost divided by 4!).
>
> Wow, nice catch.  If I read the code correctly, it detects hard links
> and replaces them with symlinks.

Yes.

> Could we do this unconditionally in a gnu-build-system phase?  Are
> there any legitimate uses of hard links in outputs?

Good question.  There might be situations where the software relies on
having regular files (not symlinks), so I would rather do it on a
case-by-case basis than have a standard phase.  WDYT?

Besides, a phase that looks at all the files would have to be efficient
than this naïve implementation.

> That said, the patch LGTM.

Pushed as dcc00f54c619118d11982383102d2e9a1b86d080, thanks!

Ludo’.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]