[debbugs-tracker] bug#29496: closed ([PATCH] doc: Update the example VCS snapshot package definition.)

[GNU bug Tracking System]

Your message dated Thu, 30 Nov 2017 12:21:53 -0500
with message-id <address@hidden>
and subject line Re: [bug#29496] [PATCH] doc: Update the example VCS snapshot 
package definition.
has caused the debbugs.gnu.org bug report #29496,
regarding [PATCH] doc: Update the example VCS snapshot package definition.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
29496: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29496
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] doc: Update the example VCS snapshot package definition.
>
>
>
>
> Date: 
>
> Tue, 28 Nov 2017 18:38:53 -0500
>
>
>
>
> In commit ee17a9e06e636400e3354796a42ac445dbcc8f96, the helpers git-version
> and git-file-name removed the need to build version and file name strings
> manually for packages that use VCS snapshots.
>
> doc/guix.texi (Version Numbers): Use git-version and git-file-name.
> ---
>  doc/guix.texi | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/doc/guix.texi b/doc/guix.texi
> index 777ca2738..0bd6b6a79 100644
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -19880,16 +19880,14 @@ definition may look like this:
>    (let ((commit "c3f29bc928d5900971f65965feaae59e1272a3f7")
>          (revision "1"))          ;Guix package revision
>      (package
> -      (version (string-append "0.9-" revision "."
> -                              (string-take commit 7)))
> +      (version (git-version "0.9" revision commit))
>        (source (origin
>                  (method git-fetch)
>                  (uri (git-reference
>                        (url "git://example.org/my-package.git")
>                        (commit commit)))
>                  (sha256 (base32 "address@hidden"))
> -                (file-name (string-append "my-package-" version
> -                                          "-checkout"))))
> +                (file-name (git-file-name name version))))
>        ;; @dots{}
>        )))
>  @end example
> -- 
> 2.15.0
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#29496] [PATCH] doc: Update the example VCS snapshot package definition. Date: Thu, 30 Nov 2017 12:21:53 -0500 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)

address@hidden (Ludovic Courtès) writes:

> Kei Kebreau <address@hidden> skribis:
>
>> In commit ee17a9e06e636400e3354796a42ac445dbcc8f96, the helpers git-version
>> and git-file-name removed the need to build version and file name strings
>> manually for packages that use VCS snapshots.
>>
>> doc/guix.texi (Version Numbers): Use git-version and git-file-name.
>
> LGTM, thanks!
>
> Ludo’, who didn’t know about ‘git-version’.

Pushed! Thanks to you for reviewing and to Leo for making me this change.

signature.asc
Description: PGP signature

--- End Message ---