[debbugs-tracker] bug#29646: closed ([PATCH] skalibs reproducible issue (reopen))

[GNU bug Tracking System]

Your message dated Mon, 11 Dec 2017 17:08:35 +0100
with message-id <address@hidden>
and subject line Re: [bug#29646] [PATCH] skalibs reproducible issue (reopen)
has caused the debbugs.gnu.org bug report #29646,
regarding [PATCH] skalibs reproducible issue (reopen)
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
29646: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29646
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] skalibs reproducible issue (reopen) Date: Sun, 10 Dec 2017 23:42:30 +0800 User-agent: Mutt/1.6.0 (2016-04-01)

Hi!
Previously, we submitted a patch that intended to fix the unreproducible issue 
of the package skalibs (#28017). Unfortunately, the patch we submitted only 
partially fixed the issues, i.e,. for the .a file (lib/skalibs/libskarnet.a). 
However, the .so file (lib/libskarnet.so) is still non-deterministic.

After investigation, we find that in the Makefile, 'sort' should be applied 
associated with 'wildcard', rather than with only ALL_SRCS. 

To validate the fix, we applied "guix build --check --no-grafts --rounds=2 
skalibs" with the patched skarnet.scm, over three PCs (with guix 
316fd29f9b6b0941367f54f431ef99695b16a9e5), and checked the sha256sum of the 
built files. Under our testing setup, the attached patch fixes the issues for 
the .a/.so files for skalibs. Hope the patch is correct this time, and sorry 
that the previous submitted patch failed to resolve all the unreproducible 
issues.

Regards,
Ren

0001-fix-the-unreproducible-issue-for-skalibs.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#29646] [PATCH] skalibs reproducible issue (reopen)
>
>
>
>
> Date: 
>
> Mon, 11 Dec 2017 17:08:35 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)
>
>
>
>
> Hello,
>
> "Z. Ren" <address@hidden> skribis:
>
> > Previously, we submitted a patch that intended to fix the unreproducible 
> > issue of the package skalibs (#28017). Unfortunately, the patch we submitted 
> > only partially fixed the issues, i.e,. for the .a file 
> > (lib/skalibs/libskarnet.a). However, the .so file (lib/libskarnet.so) is 
> > still non-deterministic.
> >
> > After investigation, we find that in the Makefile, 'sort' should be applied 
> > associated with 'wildcard', rather than with only ALL_SRCS. 
> >
> > To validate the fix, we applied "guix build --check --no-grafts --rounds=2 
> > skalibs" with the patched skarnet.scm, over three PCs (with guix 
> > 316fd29f9b6b0941367f54f431ef99695b16a9e5), and checked the sha256sum of the 
> > built files. Under our testing setup, the attached patch fixes the issues for 
> > the .a/.so files for skalibs. Hope the patch is correct this time, and sorry 
> > that the previous submitted patch failed to resolve all the unreproducible 
> > issues.
>
> I confirm that it builds reproducibly on my laptop with --rounds=2 (a
> weaker test that what you did!).
>
> > From 36e35a72942a561028f93e6905cab7729a0d1f12 Mon Sep 17 00:00:00 2001
> > From: Z. Ren <address@hidden>
> > Date: Sun, 10 Dec 2017 22:23:32 +0800
> > Subject: [PATCH] fix the unreproducible issue for skalibs
> >
> > ---
> >  gnu/packages/skarnet.scm | 4 ++--
>
> I adjusted the commit log and committed.
>
> Thank you!
>
> Ludo’.
>
>
> --- End Message ---