emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#30302: closed ([[PATCH core-updates]] gnu: python-


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#30302: closed ([[PATCH core-updates]] gnu: python-gevent: Update to 1.2.2.)
Date: Thu, 01 Feb 2018 10:13:02 +0000

Your message dated Thu, 01 Feb 2018 11:12:17 +0100
with message-id <address@hidden>
and subject line Re: [[PATCH core-updates]] gnu: python-gevent: Update to 1.2.2.
has caused the debbugs.gnu.org bug report #30302,
regarding [[PATCH core-updates]] gnu: python-gevent: Update to 1.2.2.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
30302: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=30302
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: [[PATCH core-updates]] gnu: python-gevent: Update to 1.2.2. Date: Wed, 31 Jan 2018 13:06:39 +0100
* gnu/packages/python.scm (python-gevent): Update to 1.2.2.
[source](snippet): Adjust to moved software bundles.  Remove greentest 
substitution.
[arguments]: Add #:modules.  Add phases 'unpack-libev', 'patch-hard-coded-paths'
and 'do-not-use-bundled-sources' and replace check phase with a custom command.
[native-inputs]: Add LIBEV source.
---
 gnu/packages/python.scm | 65 +++++++++++++++++++++++++++++++++++++++++--------
 1 file changed, 55 insertions(+), 10 deletions(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 9d9870032..edc6ea4e4 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -26,7 +26,7 @@
 ;;; Copyright © 2016, 2017 ng0 <address@hidden>
 ;;; Copyright © 2016 Dylan Jeffers <address@hidden@openmailbox.org>
 ;;; Copyright © 2016 David Craven <address@hidden>
-;;; Copyright © 2016, 2017 Marius Bakke <address@hidden>
+;;; Copyright © 2016, 2017, 2018 Marius Bakke <address@hidden>
 ;;; Copyright © 2016, 2017 Stefan Reichör <address@hidden>
 ;;; Copyright © 2016 Dylan Jeffers <address@hidden@openmailbox.org>
 ;;; Copyright © 2016, 2017 Alex Vong <address@hidden>
@@ -8561,28 +8561,73 @@ are synchronized with data exchanges on \"channels\".")
 (define-public python-gevent
   (package
     (name "python-gevent")
-    (version "1.1.1")
+    (version "1.2.2")
     (source (origin
               (method url-fetch)
               (uri (pypi-uri "gevent" version))
               (sha256
                (base32
-                "1smf3kvidpdiyi2c81alal74p2zm0clrm6xbyy6y1k9a3f2vkrbf"))
+                "0bbbjvi423y9k9xagrcsimnayaqymg6f2dj76m9z3mjpkjpci4a7"))
               (modules '((guix build utils)))
               (snippet
                '(begin
                   ;; unbunding libev and c-ares
-                  (for-each delete-file-recursively '("libev" "c-ares"))
-                  ;; fixing testsuite
-                  (call-with-output-file "greentest/__init__.py" noop)
-                  (substitute* "greentest/testrunner.py"
-                    (("import util") "from . import util")
-                    (("from util import log") "from .util import log"))))))
+                  (delete-file-recursively "deps")
+                  #t))))
     (build-system python-build-system)
+    (arguments
+     `(#:modules ((ice-9 ftw)
+                  (srfi srfi-26)
+                  (guix build utils)
+                  (guix build python-build-system))
+       #:phases (modify-phases %standard-phases
+                  (add-after 'unpack 'unpack-libev
+                    (lambda* (#:key inputs #:allow-other-keys)
+                      (mkdir-p "deps/libev")
+                      ;; FIXME: gevent requires building libev, even though
+                      ;; it only links against the proper one.
+                      (invoke "tar" "-xf" (assoc-ref inputs "libev-source")
+                              "--strip-components=1" "-C" "deps/libev")))
+                  (add-before 'patch-source-shebangs 'patch-hard-coded-paths
+                    (lambda _
+                      (substitute* "src/gevent/subprocess.py"
+                        (("/bin/sh") (which "sh")))
+                      (for-each (lambda (file)
+                                  (substitute* file
+                                    (("/bin/sh") (which "sh"))
+                                    (("/bin/true") (which "true"))))
+                                (find-files "src/greentest" "\\.py$"))
+                      #t))
+                  (add-before 'build 'do-not-use-bundled-sources
+                    (lambda _
+                      (setenv "CONFIG_SHELL" (which "bash"))
+                      (setenv "LIBEV_EMBED" "false")
+                      (setenv "CARES_EMBED" "false")
+                      (setenv "EMBED" "false")
+                      #t))
+                  (replace 'check
+                    (lambda _
+                      ;; Make sure the build directory is on PYTHONPATH.
+                      (setenv "PYTHONPATH"
+                              (string-append
+                               (getenv "PYTHONPATH") ":"
+                               (getcwd) "/build/"
+                               (car (scandir "build" (cut string-prefix? 
"lib." <>)))))
+                      (with-directory-excursion "src/greentest"
+                        ;; XXX: Many tests require network access.  Instead we 
only
+                        ;; run known-good tests.  Unfortunately we cannot use
+                        ;; recursion here since this directory also contains
+                        ;; Python-version-specific subfolders.
+                        (apply invoke "python" "testrunner.py" "--config"
+                               "known_failures.py"
+                               (scandir "." (cut regexp-exec
+                                                 (make-regexp 
"test_+(subprocess|core)")
+                                                 <>)))))))))
     (propagated-inputs
      `(("python-greenlet" ,python-greenlet)))
     (native-inputs
-     `(("python-six" ,python-six)))
+     `(("libev-source" ,(package-source libev))
+       ("python-six" ,python-six)))
     (inputs
      `(("c-ares" ,c-ares)
        ("libev" ,libev)))
-- 
2.16.1




--- End Message ---
--- Begin Message --- Subject: Re: [[PATCH core-updates]] gnu: python-gevent: Update to 1.2.2. Date: Thu, 01 Feb 2018 11:12:17 +0100 User-agent: Notmuch/0.26 (https://notmuchmail.org) Emacs/25.3.1 (x86_64-pc-linux-gnu)
Marius Bakke <address@hidden> writes:

> * gnu/packages/python.scm (python-gevent): Update to 1.2.2.
> [source](snippet): Adjust to moved software bundles.  Remove greentest 
> substitution.
> [arguments]: Add #:modules.  Add phases 'unpack-libev', 
> 'patch-hard-coded-paths'
> and 'do-not-use-bundled-sources' and replace check phase with a custom 
> command.
> [native-inputs]: Add LIBEV source.

I pushed this as fcaab9c0e5b339c854a895803dd3b6113e513040 to
core-updates since it fixes a few dependent packages.

Attachment: signature.asc
Description: PGP signature


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]