[debbugs-tracker] bug#31087: closed ([PATCH] gnu: Add libcgroup.)

[GNU bug Tracking System]

Your message dated Tue, 10 Apr 2018 12:05:59 +0200
with message-id <address@hidden>
and subject line Re: [bug#31087] [PATCH] gnu: Add libcgroup.
has caused the debbugs.gnu.org bug report #31087,
regarding [PATCH] gnu: Add libcgroup.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
31087: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=31087
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: Add libcgroup.
>
>
>
>
> Date: 
>
> Sat,  7 Apr 2018 13:21:25 +0200
>
>
>
>
>  * gnu/packages/linux.scm (libcgroup): New variable.
> ---
>  gnu/packages/linux.scm | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
>
> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index b6333af99..18956bd0f 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -4562,3 +4562,32 @@ text-mode or graphical applications that don't use a 
> display server.
>  Also included is @command{fbgrab}, a wrapper around @command{fbcat} that
>  emulates the behaviour of Gunnar Monell's older fbgrab utility.")
>      (license license:gpl2)))
> +
> +(define-public libcgroup
> +  (package
> +    (name "libcgroup")
> +    (version "0.41")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "mirror://sourceforge/libcg/" name "/"
> +             version "/" name "-" version ".tar.bz2"))
> +       (sha256
> +        (base32 "0lgvyq37gq84sk30sg18admxaj0j0p5dq3bl6g74a1ppgvf8pqz4"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         ;; tests try to mount cgroup filesystem and fails because it seems it
> +         ;; can't be mounted twice
> +         ;; let's disable it
> +         (delete 'check))))
> +    (native-inputs
> +     `(("bison" ,bison)
> +       ("flex" ,flex)
> +       ("linux-pam" ,linux-pam)))
> +    (home-page "https://sourceforge.net/projects/libcg/";)
> +    (synopsis "Userspace interface to control groups features in Linux kernel")
> +    (description "TBD")
> +    (license license:lgpl2.1)))
> -- 
> 2.16.3
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#31087] [PATCH] gnu: Add libcgroup. Date: Tue, 10 Apr 2018 12:05:59 +0200 User-agent: Mutt/1.9.4 (2018-02-28)

On Mon, Apr 09, 2018 at 10:35:45PM +0200, Ludovic Courtès wrote:

Hello,

Tomáš Čech <address@hidden> skribis:

 * gnu/packages/linux.scm (libcgroup): New variable.

[...]

+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         ;; tests try to mount cgroup filesystem and fails because it seems it
+         ;; can't be mounted twice
+         ;; let's disable it
+         (delete 'check))))

Simply write #:tests? #f.

+    (native-inputs
+     `(("bison" ,bison)
+       ("flex" ,flex)
+       ("linux-pam" ,linux-pam)))

Should ‘linux-pam’ be in ‘inputs’ rather than ‘native-inputs’?

Otherwise LGTM, thanks!

Both things addressed, result pushed.

Thanks for review!

S_W

signature.asc
Description: PGP signature

--- End Message ---