emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#29732: closed ([PATCH 0/1] Add a DHCP daemon servi


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#29732: closed ([PATCH 0/1] Add a DHCP daemon service)
Date: Sun, 22 Apr 2018 07:45:01 +0000

Your message dated Sun, 22 Apr 2018 00:44:20 -0700
with message-id <address@hidden>
and subject line Re: [bug#29732] [PATCH 1/1] services: Add dhcpd-service-type 
and <dhcpd-configuration>.
has caused the debbugs.gnu.org bug report #29732,
regarding [PATCH 0/1] Add a DHCP daemon service
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
29732: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29732
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: [PATCH 0/1] Add a DHCP daemon service Date: Sat, 16 Dec 2017 00:35:28 -0800
Hi,

The following patch adds a DHCP daemon service.  It applies cleanly to
commit 341bddb31542d03bef35b1234e6e9466be337798.

I haven't found the time to add system tests yet, and I'm not sure how
easy it would be to do that (wouldn't such a system test require at
least two marionetted VMs?  Or is it possible to do it with just
one?).  Any thoughts about how to do that would be welcome.

In addition, I decided not to provide any kind of Guile scheme
representation for the daemon's config file, since that was the
quickest way for me to get a working DHCP daemon service.  I think it
makes sense to let a user specify a config file explicitly, like this
patch does.  I also think it would be neat to provide a way to
configure the daemon in Guile scheme, like we do for other services
such as openssh.  Any thoughts on this front would be welcome, too.

Chris Marusich (1):
  services: Add dhcpd-service-type and <dhcpd-configuration>.

 doc/guix.texi               | 17 +++++++++++
 gnu/services/networking.scm | 72 +++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 89 insertions(+)

-- 
2.15.1




--- End Message ---
--- Begin Message --- Subject: Re: [bug#29732] [PATCH 1/1] services: Add dhcpd-service-type and <dhcpd-configuration>. Date: Sun, 22 Apr 2018 00:44:20 -0700 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)
address@hidden (Ludovic Court├Ęs) writes:

>> For now, it's nice enough, I think, that we have a DHCPv4 system test!
>> Please let me know what you think.
>
> I agree, nice job!

Thank you!  I hope this service proves useful to somebody besides just
me!

> Please mention the gnu/tests/networking.scm changes in the log.

Good catch; I've fixed the ChangeLog entry.  I've also added
documentation for <dhcpd-configuration> in the manual, since users
deserve good documentation.  I've committed all this as
f1104d900978900addad731dfec4e0e6e5765fbe.

Thank you both for your helpful review!

-- 
Chris

Attachment: signature.asc
Description: PGP signature


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]