emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#31942: closed ([PATCH] pack: Fix guix pack -f dock


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#31942: closed ([PATCH] pack: Fix guix pack -f docker.)
Date: Sun, 24 Jun 2018 08:27:02 +0000

Your message dated Sun, 24 Jun 2018 09:26:06 +0100
with message-id <address@hidden>
and subject line Re: [bug#31942] [PATCH] pack: Fix guix pack -f docker.
has caused the debbugs.gnu.org bug report #31942,
regarding [PATCH] pack: Fix guix pack -f docker.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
31942: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=31942
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: [PATCH] pack: Fix guix pack -f docker. Date: Fri, 22 Jun 2018 22:46:37 +0100
Without this change, running guix pack fails as (guix sets) is missing when
compiling (guix build store-copy).

* guix/scripts/pack.scm (docker-image): Move (guix build store-copy) to within
the source-module-closure call.
---
 guix/scripts/pack.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/guix/scripts/pack.scm b/guix/scripts/pack.scm
index ed876b259..443d199be 100644
--- a/guix/scripts/pack.scm
+++ b/guix/scripts/pack.scm
@@ -364,9 +364,9 @@ the image."
   (define build
     ;; Guile-JSON is required by (guix docker).
     (with-extensions (list json)
-      (with-imported-modules `(,@(source-module-closure '((guix docker))
+      (with-imported-modules `(,@(source-module-closure '((guix docker)
+                                                          (guix build 
store-copy))
                                                         #:select? not-config?)
-                               (guix build store-copy)
                                ((guix config) => ,config))
         #~(begin
             (use-modules (guix docker) (srfi srfi-19) (guix build store-copy))
-- 
2.17.1




--- End Message ---
--- Begin Message --- Subject: Re: [bug#31942] [PATCH] pack: Fix guix pack -f docker. Date: Sun, 24 Jun 2018 09:26:06 +0100 User-agent: mu4e 1.0; emacs 26.1
Ludovic Court├Ęs <address@hidden> writes:

> Hi Chris!
>
> Christopher Baines <address@hidden> skribis:
>
>> Without this change, running guix pack fails as (guix sets) is missing when
>> compiling (guix build store-copy).
>>
>> * guix/scripts/pack.scm (docker-image): Move (guix build store-copy) to 
>> within
>> the source-module-closure call.
>
> Good catch, got for it!

Great, I've pushed this now.

Note that the squashfs format looks to be similarly broken, but not
quite as simple to fix.

Attachment: signature.asc
Description: PGP signature


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]