--- Begin Message ---
|
Subject: |
[PATCH 1/4] gnu: Add go-github-com-sirupsen-logrus. |
|
Date: |
Mon, 18 Jun 2018 17:15:43 +0200 |
* gnu/packages/golang.scm (go-github-com-sirupsen-logrus): New variable.
---
gnu/packages/golang.scm | 34 ++++++++++++++++++++++++++++++++++
1 file changed, 34 insertions(+)
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 6c21181da..3d1fc5b6d 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -1703,3 +1703,37 @@ incoming requests to their respective handler.")
"Pflag is library to replace Go's flag package, implementing
POSIX/GNU-style --flags.")
(license license:bsd-3))))
+
+(define-public go-github-com-sirupsen-logrus
+ (let ((commit "4b6ea7319e214d98c938f12692336f7ca9348d6b")
+ (revision "0"))
+ (package
+ (name "go-github-com-sirupsen-logrus")
+ (version (git-version "0.0.0" revision commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/sirupsen/logrus.git";)
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "06wnl1dkkib2zpm31aavk5c4290s64h2ss68nl1vgcbxzsfbxjaq"))))
+ (build-system go-build-system)
+ (native-inputs
+ `(("go-golang-org-x-crypto-ssh-terminal"
+ ,go-golang-org-x-crypto-ssh-terminal)
+ ("go-github-com-stretchr-testify"
+ ,go-github-com-stretchr-testify)
+ ("go-golang-org-x-sys-unix"
+ ,go-golang-org-x-sys-unix)))
+ (arguments
+ '(#:tests? #f ;FIXME missing dependencies
+ #:import-path "github.com/sirupsen/logrus"))
+ (home-page "https://github.com/sirupsen/logrus";)
+ (synopsis "This packages is structured, pluggable logging for Go")
+ (description
+ "Logrus is a structured logger for Go, completely API compatible with
+the standard library logger.")
+ (license license:expat))))
--
2.17.0
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: [bug#31881] [PATCH 4/4] gnu: Add go-github-com-docker-distribution. |
|
Date: |
Sat, 07 Jul 2018 18:08:33 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Hello!
Pierre-Antoine Rouby <address@hidden> skribis:
>> From: "Leo Famulari" <address@hidden>
>>> + (source
>>> + (origin
>>> + (method git-fetch)
>>> + (uri (git-reference
>>> + (url "https://github.com/docker/distribution";)
>>> + (commit commit)))
>>
>> This bundles its entire dependency graph, including the logrus module
>> you just packaged, and some other things we have packaged:
>
> I'm not sure vendor version is the same as package version. I have the
> impression some Go package have no tag or CHANGELOG, so I'm not sure for
> compatibility. Without explicit version number I thinks is more sure to
> use the vendor version.
>
>> I think it's okay to add the package with the bundled code if everything
>> is freely licensed. Can you confirm that it is?
>
> Yes, everything is free.
Based on this I went ahead and applied it, but I added a FIXME about
bundling.
P-A, could you look into unbundling at least those that are already
packaged?
Thank you!
Ludo’.
--- End Message ---