[debbugs-tracker] bug#32249: closed ([BUGFIX] cmp -b mangles result)

[GNU bug Tracking System]

Your message dated Tue, 24 Jul 2018 10:20:21 -0700
with message-id <address@hidden>
and subject line Re: [bug-diffutils] bug#32249: [BUGFIX] cmp -b mangles result
has caused the debbugs.gnu.org bug report #32249,
regarding [BUGFIX] cmp -b mangles result
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
32249: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=32249
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [BUGFIX] cmp -b mangles result Date: Mon, 23 Jul 2018 06:48:26 +0000

Hi. count_newlines is passed the wrong buffer length (off-by-one) so it
overwrites first differing byte in first file's buffer. Attached patch
fixes.

Actual:

$ cmp -b <(echo bad) <(echo bug)
[snip] differ: byte 2, line 1 is  12 ^J 165 u


Expected:

$ cmp -b <(echo bad) <(echo bug)
[snip] differ: byte 2, line 1 is 141 a 165 u

Cheers!

--mancha

cmp-newlines.patch
Description: Text document

pgpmii5vxcH6X.pgp
Description: PGP signature

--- End Message ---

--- Begin Message --- Subject: Re: [bug-diffutils] bug#32249: [BUGFIX] cmp -b mangles result Date: Tue, 24 Jul 2018 10:20:21 -0700 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 Thanks for the bug report. I suspect that fix won't work in general, though, and I installed the attached fix instead.

0001-cmp-fix-bug-in-b-diagnostic.patch
Description: Text Data

--- End Message ---