[debbugs-tracker] bug#32304: closed (27.0.50; tramp-tests issue with double slash)

[GNU bug Tracking System]

Your message dated Fri, 10 Aug 2018 09:27:48 +0200
with message-id <address@hidden>
and subject line Re: bug#32304: 27.0.50; tramp-tests issue with double slash
has caused the debbugs.gnu.org bug report #32304,
regarding 27.0.50; tramp-tests issue with double slash
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
32304: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=32304
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: 27.0.50; tramp-tests issue with double slash Date: Sun, 29 Jul 2018 11:54:10 -0400 User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

The following parts of tramp-test04-substitute-in-file-name are failing
on Cygwin (and probably also on MS-Windows, but I can't easily test
that):

(should
   (string-equal
    (substitute-in-file-name "/method:host://foo") "/method:host:/foo"))
(should

(string-equal (substitute-in-file-name "/method:host:/path///foo") "/foo"))

(should
   (string-equal (substitute-in-file-name "/method:host://~foo") "/~foo"))

Here are the corresponding evaluations:

(substitute-in-file-name "/method:host://foo")
"/method:host://foo"

(substitute-in-file-name "/method:host:/path///foo")
"//foo"

(substitute-in-file-name "/method:host://~foo")
"//~foo"

This is a consequence of the fact that Tramp calls
substitute-in-file-name on the local part of the file name:

(substitute-in-file-name "//foo")
"//foo"

(substitute-in-file-name "/path///foo")
"//foo"

(substitute-in-file-name "//~foo")
"//~foo"

"//" has a special meaning at the beginning of a file name on Cygwin and
MS-Windows; see the comment near the beginning of
search_embedded_absfilename.  So I don't think there's a real bug here.
Maybe the expected result of the test should simply be adjusted, as in
the attached patch.  Someone who builds on MS-Windows would have to
check this.

Ken

0001-Adjust-expected-results-on-a-tramp-test.patch
Description: Text document

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#32304: 27.0.50; tramp-tests issue with double slash
>
>
>
>
> Date: 
>
> Fri, 10 Aug 2018 09:27:48 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
>
>
>
>
> Version: 27.1
>
> Eli Zaretskii <address@hidden> writes:
>
> >> Should be fixed now in master. Could you, pls recheck? (I haven't tested
> >> on MS Windows today)
> >
> > Thanks, it works now as expected.
>
> Thanks for checking, I'm closing the bug.
>
> Best regards, Michael.
>
>
> --- End Message ---