--- Begin Message ---
Subject: |
[PATCH] gnu: maxima: Fix tests on i686 and x86_64. |
Date: |
Thu, 8 Nov 2018 17:27:17 -0500 |
* gnu/packages/maths.scm (maxima)[arguments]: Replace check phase.
---
gnu/packages/maths.scm | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 808ab5345..389343051 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -2716,6 +2716,18 @@ to BMP, JPEG or PNG image formats.")
(lambda _
(chmod "src/maxima" #o555)
#t))
+ (replace 'check
+ (lambda _
+ ;; This is derived from the testing code in the "debian/rules"
file
+ ;; of Debian's Maxima package.
+ ;; If Maxima can successfully run this, the binary to be installed
+ ;; should be fine.
+ (zero?
+ (system
+ (string-append "./maxima-local "
+ "--lisp=gcl "
+ "--batch-string=\"run_testsuite();\" "
+ "| grep -q \"No unexpected errors found\"")))))
;; Make sure the doc and emacs files are found in the
;; standard location. Also configure maxima to find gnuplot
;; without having it on the PATH.
--
2.19.1
--- End Message ---
--- Begin Message ---
Subject: |
Re: [bug#33322] [PATCH] gnu: maxima: Fix tests on i686 and x86_64. |
Date: |
Sun, 18 Nov 2018 12:03:16 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
address@hidden (Ludovic Courtès) writes:
> Hello,
>
> Kei Kebreau <address@hidden> skribis:
>
>> * gnu/packages/maths.scm (maxima)[arguments]: Replace check phase.
>
> [...]
>
>> + ;; This is derived from the testing code in the "debian/rules"
>> file
>> + ;; of Debian's Maxima package.
>> + ;; If Maxima can successfully run this, the binary to be installed
>> + ;; should be fine.
>> + (zero?
>> + (system
>> + (string-append "./maxima-local "
>> + "--lisp=gcl "
>> + "--batch-string=\"run_testsuite();\" "
>> + "| grep -q \"No unexpected errors
>> found\"")))))
>
> So the exit code without grep isn’t good enough, right?
>
> If it has to be this way, so be it!
>
Yes, because I think that Maxima returns successfully as long as it
exits without the underlying Lisp implementation crashing.
> Thanks,
> Ludo’.
Thank you for the review!
--- End Message ---