[debbugs-tracker] bug#33448: closed ([PATCH] describe: Fix 'format' option.)

[GNU bug Tracking System]

Your message dated Thu, 22 Nov 2018 21:23:06 +0300
with message-id <address@hidden>
and subject line Re: [bug#33448] [PATCH 2/3] describe: Add json format.
has caused the debbugs.gnu.org bug report #33448,
regarding [PATCH] describe: Fix 'format' option.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
33448: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33448
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] describe: Fix 'format' option.
>
>
>
>
> Date: 
>
> Wed, 21 Nov 2018 01:26:16 +0300
>
>
>
>
> Fix ‘guix describe’ ignores ‘--format=FORMAT’ option.
>
> * guix/scripts/describe.scm (%options): Fix 'format' option.
> ---
>  guix/scripts/describe.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/guix/scripts/describe.scm b/guix/scripts/describe.scm
> index e59502076..d3203e992 100644
> --- a/guix/scripts/describe.scm
> +++ b/guix/scripts/describe.scm
> @@ -40,7 +40,7 @@
>                  (lambda (opt name arg result)
>                    (unless (member arg '("human" "channels"))
>                      (leave (G_ "~a: unsupported output format~%") arg))
> -                  (alist-cons 'format 'channels result)))
> +                  (alist-cons 'format (string->symbol arg) result)))
>          (option '(#\h "help") #f #f
>                  (lambda args
>                    (show-help)
> -- 
> 2.19.1
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#33448] [PATCH 2/3] describe: Add json format. Date: Thu, 22 Nov 2018 21:23:06 +0300 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

address@hidden (Ludovic Courtès) writes:

[…]

>> <channel> should be exported in (guix channels) in this case.  Is it OK?
>
> No I think we should avoid exporting <channel>, but anyway we can write
> this procedure as:
>
>   (lambda (channel)
>     (scm->json-string `((name . ,(channel-name channel)) …)))

Oh, sure.  Thank you for a reminder.

Pushed as:
--8<---------------cut here---------------start------------->8---
85e9c4b91990008f2b6b07c5de6f14427d7c3a06 describe: Add recutils format.
81a40ee0cb925bc39e3044bddcfdd38ddb04f04d describe: Add json format.
8548f995494d8d6358e6a8d7bc3b3bb5a0cbecb5 describe: Use a procedure to format 
output.
--8<---------------cut here---------------end--------------->8---

Thanks,
Oleg.

signature.asc
Description: PGP signature

--- End Message ---