[debbugs-tracker] bug#33518: closed ([PATCH] gnu: Add vimb.)

[GNU bug Tracking System]

Your message dated Tue, 27 Nov 2018 12:11:55 +0100
with message-id <address@hidden>
and subject line Re: [bug#33518] [PATCH] gnu: Add vimb.
has caused the debbugs.gnu.org bug report #33518,
regarding [PATCH] gnu: Add vimb.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
33518: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33518
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: Add vimb.
>
>
>
>
> Date: 
>
> Mon, 26 Nov 2018 22:29:14 +0100
>
>
>
>
> * gnu/packages/web-browsers.scm (vimb): New variable.
> ---
>  gnu/packages/web-browsers.scm | 35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
>
> diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm
> index 2c2767dbb..052d29dd2 100644
> --- a/gnu/packages/web-browsers.scm
> +++ b/gnu/packages/web-browsers.scm
> @@ -320,3 +320,38 @@ access.")
>      (description "qutebrowser is a keyboard-focused browser with a minimal
>  GUI.  It is based on PyQt5 and QtWebKit.")
>      (license license:gpl3+)))
> +
> +(define-public vimb
> +  (package
> +    (name "vimb")
> +    (version "3.3.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/fanglingsu/vimb/archive/";
> +                           version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0v3daxs10nndxvcpvx8377aylfdismzkys5n5cs8m89c3fdy6vsw"))))
> +    (build-system glib-or-gtk-build-system)
> +    (arguments
> +     '(#:tests? #f ; no tests
> +       #:make-flags (list "CC=gcc"
> +                          "DESTDIR="
> +                          (string-append "PREFIX=" %output))
> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure))))
> +    (inputs
> +     `(("glib-networking" ,glib-networking)
> +       ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
> +       ("webkitgtk" ,webkitgtk)))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (home-page "https://fanglingsu.github.io/vimb/";)
> +    (synopsis "Fast and lightweight vim like web browser")
> +    (description "Vimb is a fast and lightweight vim like web browser based on
> +the webkit web browser engine and the GTK toolkit. Vimb is modal like the great
> +vim editor and also easily configurable during runtime. Vimb is mostly keyboard
> +driven and does not detract you from your daily work.")
> +    (license license:gpl3+)))
> -- 
> 2.19.2
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#33518] [PATCH] gnu: Add vimb.
>
>
>
>
> Date: 
>
> Tue, 27 Nov 2018 12:11:55 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
>
>
>
>
> Hi,
>
> Timo Eisenmann <address@hidden> skribis:
>
> > * gnu/packages/web-browsers.scm (vimb): New variable.
>
> Applied with the following changes to placate ‘guix lint’ and to avoid
> GitHub auto-generated tarballs (their contents may vary over time.)
>
> Let me know if anything is amiss.
>
> Thanks!
>
> Ludo’.
>
> diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm
> index 052d29dd25..f63f269ae0 100644
> --- a/gnu/packages/web-browsers.scm
> +++ b/gnu/packages/web-browsers.scm
> @@ -6,6 +6,7 @@
>  ;;; Copyright © 2017 Eric Bavier <address@hidden>
>  ;;; Copyright © 2018 Tobias Geerinckx-Rice <address@hidden>
>  ;;; Copyright © 2018 Rutger Helling <address@hidden>
> +;;; Copyright © 2018 Timo Eisenmann <address@hidden>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -48,6 +49,7 @@
>    #:use-module (gnu packages webkit)
>    #:use-module (gnu packages xorg)
>    #:use-module (guix download)
> +  #:use-module (guix git-download)
>    #:use-module (guix build-system gnu)
>    #:use-module (guix build-system glib-or-gtk)
>    #:use-module (guix build-system python))
> @@ -327,12 +329,14 @@ GUI.  It is based on PyQt5 and QtWebKit.")
>      (version "3.3.0")
>      (source
>       (origin
> -       (method url-fetch)
> -       (uri (string-append "https://github.com/fanglingsu/vimb/archive/";
> -                           version ".tar.gz"))
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/fanglingsu/vimb/";)
> +             (commit version)))
>         (sha256
>          (base32
> -         "0v3daxs10nndxvcpvx8377aylfdismzkys5n5cs8m89c3fdy6vsw"))))
> +         "1qg18z2gnsli9qgrqfhqfrsi6g9mcgr90w8yab28nxrq4aha6brf"))
> +       (file-name (git-file-name name version))))
>      (build-system glib-or-gtk-build-system)
>      (arguments
>       '(#:tests? #f ; no tests
> @@ -349,9 +353,9 @@ GUI.  It is based on PyQt5 and QtWebKit.")
>      (native-inputs
>       `(("pkg-config" ,pkg-config)))
>      (home-page "https://fanglingsu.github.io/vimb/";)
> -    (synopsis "Fast and lightweight vim like web browser")
> +    (synopsis "Fast and lightweight Vim-like web browser")
>      (description "Vimb is a fast and lightweight vim like web browser based on
> -the webkit web browser engine and the GTK toolkit. Vimb is modal like the great
> -vim editor and also easily configurable during runtime. Vimb is mostly keyboard
> +the webkit web browser engine and the GTK toolkit.  Vimb is modal like the 
> great
> +vim editor and also easily configurable during runtime.  Vimb is mostly 
> keyboard
>  driven and does not detract you from your daily work.")
>      (license license:gpl3+)))
>
> --- End Message ---