[debbugs-tracker] bug#33800: closed ([PATCH] gnu: Add grim.)

[GNU bug Tracking System]

Your message dated Thu, 20 Dec 2018 09:03:50 +0100
with message-id <address@hidden>
and subject line Re: [bug#33800] [PATCH] gnu: Add grim.
has caused the debbugs.gnu.org bug report #33800,
regarding [PATCH] gnu: Add grim.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
33800: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33800
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] gnu: Add grim. Date: Wed, 19 Dec 2018 10:38:51 +0100

Hey Guix,

these patches add grim. Basically scrot, but for Wayland instead of X11.

0001-gnu-Add-scdoc.patch
Description: Text Data

0002-gnu-Add-grim.patch
Description: Text Data

pgpgvSQYjQ9Fq.pgp
Description: OpenPGP digital signature

--- End Message ---

--- Begin Message --- Subject: Re: [bug#33800] [PATCH] gnu: Add grim. Date: Thu, 20 Dec 2018 09:03:50 +0100

Pushed as e2dd54c09035aadce8a363c3b1faf703f025d62d and
0290f533cc879239f275e45a704334c545f77f3a with your changes, thanks for
the review!

On Wed, 19 Dec 2018 22:40:48 +0100
Ludovic Courtès <address@hidden> wrote:

> Hi,
> 
> Rutger Helling <address@hidden> skribis:
> 
> > From a55c2fedeca18627e8f0aa23efc0c78e846e40ee Mon Sep 17 00:00:00
> > 2001 From: Rutger Helling <address@hidden>
> > Date: Wed, 19 Dec 2018 10:27:28 +0100
> > Subject: [PATCH 1/2] gnu: Add scdoc.
> >
> > * gnu/packages/man.scm (scdoc): New variable.  
> 
> [...]
> 
> > +   (home-page "https://git.sr.ht/~sircmpwn/scdoc";)
> > +   (synopsis "Simple man page generator")
> > +   (description "scdoc is a simple man page generator written for
> > POSIX systems +written in C99.")  
> 
> s/written in C99/in C99/
> 
> > +   ;; MIT license, see /share/doc/scdoc-1.6.0/COPYING.
> > +   (license (x11-style "file://COPYING"))))  
> 
> Should be ‘license:expat’.
> 
> > From 793ae79c8bbd68b981f4c4b94b43784011776ede Mon Sep 17 00:00:00
> > 2001 From: Rutger Helling <address@hidden>
> > Date: Wed, 19 Dec 2018 10:31:50 +0100
> > Subject: [PATCH 2/2] gnu: Add grim.
> >
> > * gnu/packages/image.scm (grim): New variable.  
> 
> [...]
> 
> > +(define-public grim
> > +  (package
> > +  (name "grim")
> > +  (version "1.0")
> > +  (source
> > +   (origin
> > +    (method url-fetch)
> > +    (uri (string-append
> > "https://github.com/emersion/grim/archive/v"; version
> > +                        ".tar.gz"))
> > +    (file-name (string-append name "-" version ".tar.gz"))
> > +    (sha256
> > +     (base32
> > "0xkk5nqyp1px0sxz4asmchznc0q39wdx1b67ql741k8aj815km0f"))))
> > +  (build-system meson-build-system)
> > +  (native-inputs `(("pkg-config" ,pkg-config)))
> > +  (inputs `(("cairo" ,cairo)
> > +            ("libjpeg-turbo" ,libjpeg-turbo)
> > +            ("scdoc" ,scdoc)
> > +            ("wayland" ,wayland)
> > +            ("wayland-protocols" ,wayland-protocols)))
> > +  (home-page "https://github.com/emersion/grim";)
> > +  (synopsis "Grab images from a Wayland compositor")
> > +  (description "grim can grab images from a Wayland compositor.")  
> 
> s/grab images/create screenshots/ ?  That would make it easier to find
> via ‘guix package -s’.  :-)
> 
> > +  ;; MIT license.
> > +  (license (license:x11-style
> > +"https://raw.githubusercontent.com/emersion/grim/master/LICENSE";))))  
> 
> ‘license:expat’ as well, AFAICS:
> 
>   https://directory.fsf.org/wiki/License:Expat
> 
> OK with these changes, thanks!
> 
> Ludo’.

pgpfkjIwbsROL.pgp
Description: OpenPGP digital signature

--- End Message ---