[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#28691: closed (27.0.50; make-process has no file-n

From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#28691: closed (27.0.50; make-process has no file-name-handler)
Date: Sat, 22 Dec 2018 22:27:01 +0000

Your message dated Sat, 22 Dec 2018 23:26:11 +0100
with message-id <address@hidden>
and subject line Re: bug#28691: [PATCH] Add file name handler support for 
'make-process' (Bug#28691)
has caused the debbugs.gnu.org bug report #28691,
regarding 27.0.50; make-process has no file-name-handler
to be marked as done.

(If you believe you have received this mail in error, please contact

28691: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28691
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: 27.0.50; make-process has no file-name-handler Date: Tue, 03 Oct 2017 13:13:03 -0400
Package: Emacs
Version: 27.0.50

`make-process` should aim to replace not just `start-process` but also
`start-file-process`, so it needs to look up a file-name-handler.
We could do that without breaking compatibility (contrary to what
happened with `start-process`) by adding a :file keyword argument.


In GNU Emacs 27.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll 
 of 2017-09-26 built on pastel
Repository revision: 7796623e559825655cf966bd83a10179214a6fbe
Windowing system distributor 'The X.Org Foundation', version 11.0.11902000
System Description:     Debian GNU/Linux 9.1 (stretch)

Recent messages:
Type C-c C-c to toggle between editing or viewing the document.
When done with a buffer, type C-x #
New window #<window 119 on PDFDocument25.pdf> for buf PDFDocument25.pdf
Note: file is write protected
New window t for buf PDFDocument26.pdf
Type C-c C-c to toggle between editing or viewing the document.
When done with a buffer, type C-x #
New window #<window 121 on PDFDocument26.pdf> for buf PDFDocument26.pdf
Making completion list...

Configured using:
 'configure -C --enable-checking --with-modules --enable-check-lisp-object-type
 'CFLAGS=-Wall -g3 -Og -Wno-pointer-sign'

Configured features:

Important settings:
  value of $LANG: fr_CH.UTF-8
  locale-coding-system: utf-8-unix

Major mode: InactiveMinibuffer

Minor modes in effect:
  shell-dirtrack-mode: t
  diff-auto-refine-mode: t
  electric-pair-mode: t
  global-reveal-mode: t
  reveal-mode: t
  auto-insert-mode: t
  savehist-mode: t
  minibuffer-electric-default-mode: t
  global-compact-docstrings-mode: t
  url-handler-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  global-prettify-symbols-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
/home/monnier/src/emacs/elpa/packages/svg/svg hides 
/home/monnier/src/emacs/elpa/packages/ada-mode/ada-prj hides 
/home/monnier/src/emacs/elpa/packages/ada-mode/ada-stmt hides 
/home/monnier/src/emacs/elpa/packages/ada-mode/ada-mode hides 
/home/monnier/src/emacs/elpa/packages/ada-mode/ada-xref hides 
/home/monnier/src/emacs/elpa/packages/hyperbole/set hides 
/home/monnier/src/emacs/elpa/packages/crisp/crisp hides 
/home/monnier/src/emacs/elpa/packages/landmark/landmark hides 

(mail-extr emacsbug org-table ox-odt ox-latex ox-icalendar ox-html
ox-ascii ox-publish ox org-protocol org-mouse org-mobile org-agenda
org-indent org-feed org-crypt org-capture org-attach org-id org-rmail
org-mhe org-irc org-info org-gnus org-docview org-bibtex bibtex org-bbdb
org-w3m org-element avl-tree generator org org-macro org-footnote
org-pcomplete org-list org-faces org-entities org-version ob-emacs-lisp
ob ob-tangle org-src ob-ref ob-lob ob-table ob-keys ob-exp ob-comint
ob-core ob-eval org-compat org-macs org-loaddefs cal-menu calendar
cal-loaddefs autorevert filenotify doc-view jka-compr image-mode
eieio-opt log-edit message sendmail subr-x puny dired dired-loaddefs
format-spec rfc822 mml mml-sec epa epg gnus-util rmail rmail-loaddefs
mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util
ietf-drums mail-prsvr mailabbrev mail-utils mailheader pcvs-util add-log
shell pcomplete tuareg speedbar sb-image ezimage dframe caml imenu
caml-help caml-types caml-emacs derived pcase quail typer-mode smie
vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs vc-dir html5-schema rng-xsd
xsd-regexp rng-cmpct rng-nxml nxml-mode nxml-outln nxml-rap sgml-mode
dom misearch multi-isearch cl-extra help-fns radix-tree cl-print view
tildify table rst compile rng-valid rng-loc rng-uri rng-parse nxml-parse
rng-match rng-dt rng-util rng-pttrn nxml-ns nxml-util nxml-enc xmltok
refer refer-to-bibtex refbib printing picture nroff-mode enriched
ebnf2ps ps-print ps-print-loaddefs ps-def lpr delim-col rect bib-mode
sort mpc executable copyright xscheme warnings unsafep trace testcover
shadow scheme re-builder profiler inf-lisp ielm comint ansi-color ring
gmm-utils ert pp find-func ewoc debug elp edebug cl-indent cus-edit
cus-start cus-load wid-edit vc vc-dispatcher smerge-mode vc-git
diff-mode filecache map server time-date noutline outline easy-mmode
flyspell ispell checkdoc thingatpt help-mode load-dir elec-pair reveal
autoinsert proof-site proof-autoloads cl pg-vars savehist minibuf-eldef
disp-table compact-docstrings cl-seq inline kotl-loaddefs advice info
realgud-recursive-autoloads finder-inf url-auth package easymenu
epg-config url-handlers url-parse auth-source eieio eieio-core cl-macs
eieio-loaddefs password-cache url-vars seq byte-opt gv bytecomp
byte-compile cconv cl-loaddefs cl-lib bbdb-autoloads vm-autoloads
mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode elisp-mode lisp-mode prog-mode register page menu-bar
rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock
syntax font-core term/tty-colors frame cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote dbusbind inotify
dynamic-setting font-render-setting x-toolkit x multi-tty
make-network-process emacs)

Memory information:
((conses 16 522650 87942)
 (symbols 48 42366 0) (miscs 40 5507 549) (strings 32 138632 7037)
 (string-bytes 1 3917145)
 (vectors 16 72593) (vector-slots 8 2109504 123075) (floats 8 650 473)
 (intervals 56 28434 115)
 (buffers 992 70))

--- End Message ---
--- Begin Message --- Subject: Re: bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691) Date: Sat, 22 Dec 2018 23:26:11 +0100
Am Sa., 22. Dez. 2018 um 10:09 Uhr schrieb Eli Zaretskii <address@hidden>:
> > From: Philipp Stephani <address@hidden>
> > Cc: address@hidden,
> >       Philipp Stephani <address@hidden>
> > Date: Mon, 17 Dec 2018 21:47:46 +0100
> >
> > * src/process.c (Fmake_process): Add new keyword argument
> > ':file-handler'.
> > (syms_of_process) <make-process, :file-handler>: Define new symbols.
> >
> > * lisp/files.el (file-name-non-special): Add support for
> > 'make-process'.
> >
> > * test/src/process-tests.el (make-process/file-handler/found)
> > (make-process/file-handler/not-found)
> > (make-process/file-handler/disable): New unit tests.
> > (process-tests--file-handler): New helper function.
> >
> > * test/lisp/files-tests.el
> > (files-tests-file-name-non-special-make-process): New unit test.
> >
> > * doc/lispref/files.texi (Magic File Names): Document that
> > 'make-process' can invoke file name handlers.
> >
> > * doc/lispref/processes.texi (Asynchronous Processes): Document
> > ':file-handlers' argument to 'make-process'.
> Thanks, this LGTM, but some of the tests use the Emacs binary, while
> others still use /bin/true for some reason.  What am I missing?

The one that uses /bin/true never invokes it, but only tests whether
the full argument list is passed to the handler. I've changed this now
to /some/binary to clarify that the actual string doesn't matter.

> Please also include etc/NEWS change in the log message.

Done and pushed as 039be4e025. Thanks!

--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]