[debbugs-tracker] bug#33965: closed (handling of closed file descriptors)

[GNU bug Tracking System]

Your message dated Thu, 3 Jan 2019 22:15:19 -0800
with message-id <address@hidden>
and subject line Re: [bug-diffutils] bug#33965: handling of closed file 
descriptors
has caused the debbugs.gnu.org bug report #33965,
regarding handling of closed file descriptors
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
33965: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33965
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: handling of closed file descriptors Date: Thu, 03 Jan 2019 20:42:28 +0100 User-agent: KMail/5.1.3 (Linux/4.4.0-141-generic; KDE/5.18.0; x86_64; ; )

There is a problem with the handling of closed file descriptors
in diff-3.7: As mentioned in [1], the 'new-file' test fails on HP-UX.
An investigation [2] shows that different coding techniques are needed,
depending on the desired outcome for closed file descriptors.

This patch uses a variant of (A) from [2]. Namely, the result of fcntl
can apparently be used to distinguish the substitute file descriptor
stuffed in by exec() from a regular open("/dev/null",O_RDONLY).

[1] https://lists.gnu.org/archive/html/diffutils-devel/2018-12/msg00019.html
[2] https://lists.gnu.org/archive/html/bug-gnulib/2019-01/msg00012.html

0001-Recognize-file-descriptors-closed-by-the-parent-proc.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug-diffutils] bug#33965: handling of closed file descriptors
>
>
>
>
> Date: 
>
> Thu, 3 Jan 2019 22:15:19 -0800
>
>
>
>
> On Thu, Jan 3, 2019 at 11:43 AM Bruno Haible <address@hidden> wrote:
> >
> > There is a problem with the handling of closed file descriptors
> > in diff-3.7: As mentioned in [1], the 'new-file' test fails on HP-UX.
> > An investigation [2] shows that different coding techniques are needed,
> > depending on the desired outcome for closed file descriptors.
> >
> > This patch uses a variant of (A) from [2]. Namely, the result of fcntl
> > can apparently be used to distinguish the substitute file descriptor
> > stuffed in by exec() from a regular open("/dev/null",O_RDONLY).
> >
> > [1] https://lists.gnu.org/archive/html/diffutils-devel/2018-12/msg00019.html
> > [2] https://lists.gnu.org/archive/html/bug-gnulib/2019-01/msg00012.html
>
> Thank you. I have just pushed that with one tweak to the log message:
> s/parent parent/parent/.
>
>
> --- End Message ---