[debbugs-tracker] bug#33930: closed (26.1; [PATCH] Fix `C-x C-k l' (`kmacro-edit-lossage') so it ignores mouse events)

[GNU bug Tracking System]

Your message dated Sat, 05 Jan 2019 11:38:29 +0200
with message-id <address@hidden>
and subject line Re: bug#33930: 26.1; [PATCH] Fix `C-x C-k l' 
(`kmacro-edit-lossage') so it ignores mouse events
has caused the debbugs.gnu.org bug report #33930,
regarding 26.1; [PATCH] Fix `C-x C-k l' (`kmacro-edit-lossage') so it ignores 
mouse events
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
33930: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33930
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: 26.1; [PATCH] Fix `C-x C-k l' (`kmacro-edit-lossage') so it ignores mouse events Date: Sun, 30 Dec 2018 11:37:28 -0800 (PST)

If you have used the mouse at all during the last 300 events then `C-x
C-k l' (`kmacro-edit-lossage') is broken: it just raises an error,
rather than showing you your keyboard events as a keyboard macro and
letting you edit the macro.  That's not very helpful.

This happens because `edmacro-fix-menu-commands' just punts, not
bothering to try to handle mouse events the same way it handles events
such as help-echo and switch-frame events.

The attached patch fixes that.  It also makes the error message explicit
about any unsupported event, instead of assuming that every unsupported
event is necessarily a mouse event.

In GNU Emacs 26.1 (build 1, x86_64-w64-mingw32)
 of 2018-05-30
Repository revision: 07f8f9bc5a51f5aa94eb099f3e15fbe0c20ea1ea
Windowing system distributor `Microsoft Corp.', version 10.0.16299
Configured using:
 `configure --without-dbus --host=x86_64-w64-mingw32
 --without-compress-install 'CFLAGS=-O2 -static -g3''

edmacro-2018-12-30a.patch
Description: Binary data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#33930: 26.1; [PATCH] Fix `C-x C-k l' (`kmacro-edit-lossage') so it ignores mouse events
>
>
>
>
> Date: 
>
> Sat, 05 Jan 2019 11:38:29 +0200
>
>
>
>
> > Date: Sun, 30 Dec 2018 11:37:28 -0800 (PST)
> > From: Drew Adams <address@hidden>
> > 
> > If you have used the mouse at all during the last 300 events then `C-x
> > C-k l' (`kmacro-edit-lossage') is broken: it just raises an error,
> > rather than showing you your keyboard events as a keyboard macro and
> > letting you edit the macro.  That's not very helpful.
> > 
> > This happens because `edmacro-fix-menu-commands' just punts, not
> > bothering to try to handle mouse events the same way it handles events
> > such as help-echo and switch-frame events.
> > 
> > The attached patch fixes that.  It also makes the error message explicit
> > about any unsupported event, instead of assuming that every unsupported
> > event is necessarily a mouse event.
>
> Thanks, installed on the master branch.
>
>
> --- End Message ---