[debbugs-tracker] bug#34435: closed ([PATCH 0/3] KDE updates)

[GNU bug Tracking System]

Your message dated Wed, 13 Feb 2019 00:02:12 +0100
with message-id <address@hidden>
and subject line Re: [PATCH 3/3] gnu: Add kscreenlocker.
has caused the debbugs.gnu.org bug report #34435,
regarding [PATCH 0/3] KDE updates
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
34435: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34435
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 0/3] KDE updates
>
>
>
>
> Date: 
>
> Mon, 11 Feb 2019 16:16:27 +0100
>
>
>
>
> Here are some patches I worked on for the nice Guix packaging bounty:
> <https://git.pantherx.org/bounty/bounty-001-guixsd-lxqt-kwin-wayland/issues/3>.
> (no spoilers!)
>
> @Hartmut, others: Should we split the KDE Plasma components into a
> separate (gnu packages kde-plasma) module?
>
> Hartmut Goebel (2):
>   gnu: Add kdecoration.
>   gnu: Add kscreenlocker.
>
> Marius Bakke (1):
>   gnu: KDE: Update to 5.54.0.
>
>  gnu/packages/kde-frameworks.scm               | 341 +++++++++---------
>  gnu/packages/kde.scm                          | 111 +++++-
>  .../patches/kio-search-smbd-on-PATH.patch     |   2 +-
>  3 files changed, 268 insertions(+), 186 deletions(-)
>
> -- 
> 2.20.1
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [PATCH 3/3] gnu: Add kscreenlocker. Date: Wed, 13 Feb 2019 00:02:12 +0100 User-agent: Notmuch/0.28.1 (https://notmuchmail.org) Emacs/26.1 (x86_64-pc-linux-gnu)

Hartmut Goebel <address@hidden> writes:

> Am 11.02.19 um 16:18 schrieb Marius Bakke:
>> +    (native-inputs
>> +     `(("extra-cmake-modules" ,extra-cmake-modules)
>> +       ("pkg-config" ,pkg-config)
>> +
>
> Empty line.

I like adding empty lines to "group" inputs, or as a separator to make
some things "stand out".

>> +       ("logind" ,elogind)        ;optional loginctl support
>
> According to my notes (for 5.13.5) this is a run-time dependency. Why do
> we need to list it here and not later in some "service"?

CMake tests for it, and sets HAVE_UNLOCK_CAPABILITY to TRUE when found.

I did not study the code enough to see how it is used so I left it in
for now.

> Another thing: I suggest keeping al l Plasma related packages in a
> module of it's own. This will help keeping modules small, easy to spot
> and easier to maintain.

I moved the Plasma packages to a kde-plasma module with commit
bec2a2e10e199d6ee671ec5713bd103242e91b62.  Thanks for the feedback!

signature.asc
Description: PGP signature

--- End Message ---