[debbugs-tracker] bug#34451: closed (26.1; doc-view-toggle-display chokes if default major-mode is text-mode)

[GNU bug Tracking System]

Your message dated Sat, 09 Mar 2019 22:08:11 +0100
with message-id <address@hidden>
and subject line Re: bug#34451: 26.1; doc-view-toggle-display chokes if default 
major-mode is text-mode
has caused the debbugs.gnu.org bug report #34451,
regarding 26.1; doc-view-toggle-display chokes if default major-mode is 
text-mode
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
34451: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34451
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 26.1; doc-view-toggle-display chokes if default major-mode is text-mode
>
>
>
>
> Date: 
>
> Mon, 11 Feb 2019 21:42:52 -0600
>
>
>
>
> Start `emacs -Q'
> eval  (setq-default major-mode 'text-mode)
> visit a pdf or postscript file
> Type C-c C-c twice
> doc-view-toggle-display: Wrong type argument: stringp, nil
>
> The problem is that doc-view-toggle-display assumes that if the
> major-mode is text-mode the user is viewing the document's text
> contents.  But that's incorrect if the default value of major-mode
> is text-mode so that this mode is also used for a "raw" pdf or
> postscript file.
>
>
> In GNU Emacs 26.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.18.9)
>  of 2018-05-29 built on regnitz
> Windowing system distributor 'The X.Org Foundation', version 11.0.11804000
> System Description:     Ubuntu 16.04.5 LTS
>
> Recent messages:
> For information about GNU Emacs and the GNU system, type C-h C-a.
> text-mode
> DocView: using cached files!
> Type C-c C-c to toggle between editing or viewing the document. [2 times]
> doc-view-toggle-display: Wrong type argument: stringp, nil
>
> Configured features:
> XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS NOTIFY
> ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
> TOOLKIT_SCROLL_BARS GTK3 X11 THREADS LCMS2
>
> Important settings:
>   value of $LC_COLLATE: C
>   value of $LANG: en_US.utf8
>   value of $XMODIFIERS: 
>   locale-coding-system: utf-8-unix
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#34451: 26.1; doc-view-toggle-display chokes if default major-mode is text-mode
>
>
>
>
> Date: 
>
> Sat, 09 Mar 2019 22:08:11 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
>
>
>
>
> "Roland Winkler" <address@hidden> writes:
>
> > Start `emacs -Q'
> > eval  (setq-default major-mode 'text-mode)
> > visit a pdf or postscript file
> > Type C-c C-c twice
> > doc-view-toggle-display: Wrong type argument: stringp, nil
> >
> > The problem is that doc-view-toggle-display assumes that if the
> > major-mode is text-mode the user is viewing the document's text
> > contents.  But that's incorrect if the default value of major-mode is
> > text-mode so that this mode is also used for a "raw" pdf or postscript
> > file.
>
> Right, thanks for the pointer.  Now I use a separate mode (which is
> actually just `view-mode' with a doc-view-specific value for
> major-mode).
>
> Bye,
> Tassilo
>
>
> --- End Message ---